Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7312

Pex_policy tests do not run properly unless you are in the pex_policy directory

    XMLWordPrintable

    Details

    • Story Points:
      0.25
    • Team:
      Architecture

      Description

      Some of the tests assume that policy files can be found relative to the working directory of the process running the test. This does not work if you are running tests from all packages together. The tests need to be modified to use $PEX_POLICY_DIR.

        Attachments

          Activity

          Hide
          tjenness Tim Jenness added a comment -

          Russell Owen can you review this please? If you ignore the one big whitespace commit the code changes are obvious. I just add getPackageDir where needed. Also fixed a couple of old asserts.

          Show
          tjenness Tim Jenness added a comment - Russell Owen can you review this please? If you ignore the one big whitespace commit the code changes are obvious. I just add getPackageDir where needed. Also fixed a couple of old asserts.
          Hide
          rowen Russell Owen added a comment -

          Overall this looks great. I made a few requests as github comments.

          Show
          rowen Russell Owen added a comment - Overall this looks great. I made a few requests as github comments.
          Hide
          tjenness Tim Jenness added a comment -

          Merged. Decided against changing the variable name as there were already other places in the code that did it this way.

          Show
          tjenness Tim Jenness added a comment - Merged. Decided against changing the variable name as there were already other places in the code that did it this way.

            People

            Assignee:
            tjenness Tim Jenness
            Reporter:
            tjenness Tim Jenness
            Reviewers:
            Russell Owen
            Watchers:
            Russell Owen, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins Builds

                No builds found.