Fix Version/s: None
Sprint:SUIT Sprint 2016-9, SUIT Sprint 2016-10, SUIT Sprint 2016-11
Team:Science User Interface
The Python API for Firefly has changed, due to the Firefly rewrite, and to renaming of methods to be more compatible with PEP8. This ticket updates the existing display_firefly plugin for these changes and also to ensure compatibility with Python 3.
The targeted functionality follows the testDisplay.py test in the afw package:
- Display an Exposure or MaskedImage with image and mask overlaid
- Set a specific mask plane color.
- Turn off a specific mask plane.
- Erase a display.
- Zoom to a user-specified zoom level.
- Pan to a particular pixel position.
- Display a symbol at a specific pixel position.
- Change the stretch / scale.
- Display a line with specified vertices.
Interact with the display to return a pixel coordinate that a user has clicked on.Deferred to DM-8173.
- FF-depends on
DM-7326 Adapt FireflyClient (renamed to firefly_client.py) to Python 3
Robert Lupton concerning #6: the scrolling works like google maps, which is a click and drag. I have three finger draging set on my Mac (now hidden under: System Preferences... => Accessibility => Mouse & Trackpad => Trackpad Optons... => Enable dragging).
Neither Google maps or Firefly use a "scrolled window" so the OS built in scrolling does not work.
I will make one or two tickets out of the others issues.
Note, #1 and #14 were addressed in the post-review fixes for this ticket, along with the coding comments on the pull request.
The other items were not addressed.
a two-finger gesture (on os/x) seems to go to previous/next URLs (I was trying to pan) and I lost my image
I think the issue here may be less about "there should be a nice mouse gesture for panning" and more about "it's too easy to lose your place by accidentally invoking 'Back' in the browser".
Suggestions from code review incorporated. A more informative exception message is raised when a browser tab has not be reopened to the correct URL. erase() method now erases only the overlays.
Other issues found in the review will be addressed in new tickets.