Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7321

Adapt display_firefly to new Firefly API, and to py3

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Story Points:
      10
    • Epic Link:
    • Sprint:
      SUIT Sprint 2016-9, SUIT Sprint 2016-10, SUIT Sprint 2016-11
    • Team:
      Science User Interface

      Description

      The Python API for Firefly has changed, due to the Firefly rewrite, and to renaming of methods to be more compatible with PEP8. This ticket updates the existing display_firefly plugin for these changes and also to ensure compatibility with Python 3.

      The targeted functionality follows the testDisplay.py test in the afw package:

      • Display an Exposure or MaskedImage with image and mask overlaid
      • Set a specific mask plane color.
      • Turn off a specific mask plane.
      • Erase a display.
      • Zoom to a user-specified zoom level.
      • Pan to a particular pixel position.
      • Display a symbol at a specific pixel position.
      • Change the stretch / scale.
      • Display a line with specified vertices.
      • Interact with the display to return a pixel coordinate that a user has clicked on. Deferred to DM-8173.

        Attachments

          Issue Links

          FF-depends on

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7326 Adapt FireflyClient (renamed to firefly_client.py) to Python 3

          • Done
          relates to

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. DM-6179 Support Python 3 migration

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8007 Make firefly_client pip-installable

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8171 Add keyword arguments to afwDisplay.setDefaultBackend

          • Won't Fix

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-248 Add firefly_client and ws4py as third-party packages for display_firefly

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            5 older comments
            Hide
            Permalink
            shupe David Shupe added a comment -

            Suggestions from code review incorporated. A more informative exception message is raised when a browser tab has not be reopened to the correct URL. erase() method now erases only the overlays.

            Other issues found in the review will be addressed in new tickets.

            Show
            shupe David Shupe added a comment - Suggestions from code review incorporated. A more informative exception message is raised when a browser tab has not be reopened to the correct URL. erase() method now erases only the overlays. Other issues found in the review will be addressed in new tickets.
            Hide
            Permalink
            roby Trey Roby added a comment -

            Robert Lupton concerning #6: the scrolling works like google maps, which is a click and drag. I have three finger draging set on my Mac (now hidden under: System Preferences... => Accessibility => Mouse & Trackpad => Trackpad Optons... => Enable dragging).

            Neither Google maps or Firefly use a "scrolled window" so the OS built in scrolling does not work.

            I will make one or two tickets out of the others issues.

            Show
            roby Trey Roby added a comment - Robert Lupton concerning #6: the scrolling works like google maps, which is a click and drag. I have three finger draging set on my Mac (now hidden under: System Preferences... => Accessibility => Mouse & Trackpad => Trackpad Optons... => Enable dragging). Neither Google maps or Firefly use a "scrolled window" so the OS built in scrolling does not work. I will make one or two tickets out of the others issues.
            Hide
            Permalink
            shupe David Shupe added a comment -

            Note, #1 and #14 were addressed in the post-review fixes for this ticket, along with the coding comments on the pull request.

            The other items were not addressed.

            Show
            shupe David Shupe added a comment - Note, #1 and #14 were addressed in the post-review fixes for this ticket, along with the coding comments on the pull request. The other items were not addressed.
            Hide
            Permalink
            roby Trey Roby added a comment -

            see issue: DM-8409

            Show
            roby Trey Roby added a comment - see issue: DM-8409
            Hide
            Permalink
            gpdf Gregory Dubois-Felsmann added a comment - - edited

            a two-finger gesture (on os/x) seems to go to previous/next URLs (I was trying to pan) and I lost my image

            I think the issue here may be less about "there should be a nice mouse gesture for panning" and more about "it's too easy to lose your place by accidentally invoking 'Back' in the browser".

            Show
            gpdf Gregory Dubois-Felsmann added a comment - - edited a two-finger gesture (on os/x) seems to go to previous/next URLs (I was trying to pan) and I lost my image I think the issue here may be less about "there should be a nice mouse gesture for panning" and more about "it's too easy to lose your place by accidentally invoking 'Back' in the browser".

              People

              Assignee:
              shupe David Shupe
              Reporter:
              shupe David Shupe
              Reviewers:
              Robert Lupton
              Watchers:
              David Shupe, Gregory Dubois-Felsmann, Nate Lust, Robert Lupton, Trey Roby, Xiuqin Wu [X] (Inactive)
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.