Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7321

Adapt display_firefly to new Firefly API, and to py3

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Story Points:
      10
    • Epic Link:
    • Sprint:
      SUIT Sprint 2016-9, SUIT Sprint 2016-10, SUIT Sprint 2016-11
    • Team:
      Science User Interface

      Description

      The Python API for Firefly has changed, due to the Firefly rewrite, and to renaming of methods to be more compatible with PEP8. This ticket updates the existing display_firefly plugin for these changes and also to ensure compatibility with Python 3.

      The targeted functionality follows the testDisplay.py test in the afw package:

      • Display an Exposure or MaskedImage with image and mask overlaid
      • Set a specific mask plane color.
      • Turn off a specific mask plane.
      • Erase a display.
      • Zoom to a user-specified zoom level.
      • Pan to a particular pixel position.
      • Display a symbol at a specific pixel position.
      • Change the stretch / scale.
      • Display a line with specified vertices.
      • Interact with the display to return a pixel coordinate that a user has clicked on. Deferred to DM-8173.

        Attachments

          Issue Links

          FF-depends on

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7326 Adapt FireflyClient (renamed to firefly_client.py) to Python 3

          • Done
          relates to

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. DM-6179 Support Python 3 migration

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8007 Make firefly_client pip-installable

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8171 Add keyword arguments to afwDisplay.setDefaultBackend

          • Won't Fix

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-248 Add firefly_client and ws4py as third-party packages for display_firefly

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            shupe David Shupe created issue -
            shupe David Shupe made changes -
            Field Original Value New Value
            Epic Link DM-7284 [ 26369 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2016-9 [ 223 ]
            shupe David Shupe made changes -
            Link This issue FF-depends on DM-7326 [ DM-7326 ]
            shupe David Shupe made changes -
            Link This issue relates to DM-6179 [ DM-6179 ]
            shupe David Shupe made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Story Points 3 10
            shupe David Shupe made changes -
            Description The Python API for Firefly has changed, due to the Firefly rewrite, and to renaming of methods to be more compatible with PEP8. This ticket updates the existing display_firefly plugin for these changes and also to ensure compatibility with Python 3. The Python API for Firefly has changed, due to the Firefly rewrite, and to renaming of methods to be more compatible with PEP8. This ticket updates the existing display_firefly plugin for these changes and also to ensure compatibility with Python 3.

            The targeted functionality follows the {{testDisplay.py}} test in the {{afw}} package:
            * Display an Exposure or MaskedImage with image and mask overlaid
            * Set a specific mask plane color.
            * Turn off a specific mask plane.
            * Erase a display.
            * Zoom to a user-specified zoom level.
            * Pan to a particular pixel position.
            * Display a symbol at a specific pixel position.
            * Change the stretch / scale.
            * Display a line with specified vertices.
            * Interact with the display to return a pixel coordinate that a user has clicked on.
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2016-9 [ 223 ] SUIT Sprint 2016-9, SUIT Sprint 2016-10 [ 223, 250 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Rank Ranked higher
            shupe David Shupe made changes -
            Link This issue relates to DM-8007 [ DM-8007 ]
            shupe David Shupe made changes -
            Link This issue relates to RFC-248 [ RFC-248 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Sprint SUIT Sprint 2016-9, SUIT Sprint 2016-10 [ 223, 250 ] SUIT Sprint 2016-9, SUIT Sprint 2016-10, SUIT Sprint 2016-11 [ 223, 250, 251 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Rank Ranked higher
            shupe David Shupe made changes -
            Status In Progress [ 3 ] In Review [ 10004 ]
            shupe David Shupe made changes -
            Link This issue relates to DM-8171 [ DM-8171 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Reviewers Nate Lust [ nlust ] Robert Lupton [ rhl ]
            rhl Robert Lupton made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            shupe David Shupe made changes -
            Description The Python API for Firefly has changed, due to the Firefly rewrite, and to renaming of methods to be more compatible with PEP8. This ticket updates the existing display_firefly plugin for these changes and also to ensure compatibility with Python 3.

            The targeted functionality follows the {{testDisplay.py}} test in the {{afw}} package:
            * Display an Exposure or MaskedImage with image and mask overlaid
            * Set a specific mask plane color.
            * Turn off a specific mask plane.
            * Erase a display.
            * Zoom to a user-specified zoom level.
            * Pan to a particular pixel position.
            * Display a symbol at a specific pixel position.
            * Change the stretch / scale.
            * Display a line with specified vertices.
            * Interact with the display to return a pixel coordinate that a user has clicked on.             		The Python API for Firefly has changed, due to the Firefly rewrite, and to renaming of methods to be more compatible with PEP8. This ticket updates the existing display_firefly plugin for these changes and also to ensure compatibility with Python 3.

            The targeted functionality follows the {{testDisplay.py}} test in the {{afw}} package:
            * Display an Exposure or MaskedImage with image and mask overlaid
            * Set a specific mask plane color.
            * Turn off a specific mask plane.
            * Erase a display.
            * Zoom to a user-specified zoom level.
            * Pan to a particular pixel position.
            * Display a symbol at a specific pixel position.
            * Change the stretch / scale.
            * Display a line with specified vertices.
            * -Interact with the display to return a pixel coordinate that a user has clicked on.- Deferred to DM-8173.
            shupe David Shupe made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            roby Trey Roby made changes -
            Watchers David Shupe, Gregory Dubois-Felsmann, Nate Lust, Robert Lupton, Xiuqin Wu [ David Shupe, Gregory Dubois-Felsmann, Nate Lust, Robert Lupton, Xiuqin Wu ] David Shupe, Gregory Dubois-Felsmann, Nate Lust, Robert Lupton, Trey Roby, Xiuqin Wu [ David Shupe, Gregory Dubois-Felsmann, Nate Lust, Robert Lupton, Trey Roby, Xiuqin Wu ]

              People

              Assignee:
              shupe David Shupe
              Reporter:
              shupe David Shupe
              Reviewers:
              Robert Lupton
              Watchers:
              David Shupe, Gregory Dubois-Felsmann, Nate Lust, Robert Lupton, Trey Roby, Xiuqin Wu [X] (Inactive)
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.