Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7326

Adapt FireflyClient (renamed to firefly_client.py) to Python 3

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: Firefly
    • Labels:
      None

      Description

      The stack is being adapted to work with Python 3 as well as Python 2. Following the guide from LSST2016 for porting packages to Python 3, adapt the FireflyClient API. This will allow afw.display to work with Firefly in a Python 3 stack.

        Attachments

          Issue Links

          is FF-depended by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7321 Adapt display_firefly to new Firefly API, and to py3

          • Done
          relates to

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. DM-6179 Support Python 3 migration

          • Done

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            shupe David Shupe created issue -
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Field Original Value New Value
            Epic Link DM-3604 [ 19702 ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Story Points 4
            shupe David Shupe made changes -
            Assignee David Shupe [ shupe ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Assignee David Shupe [ shupe ] Cindy Wang [ cwang ]
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Story Points 4 2
            Hide
            Permalink
            shupe David Shupe added a comment -

            The Python 3 porting guide under review is at https://sqr-014.lsst.io/v/DM-6315/index.html

            Show
            shupe David Shupe added a comment - The Python 3 porting guide under review is at https://sqr-014.lsst.io/v/DM-6315/index.html
            tjenness Tim Jenness made changes -
            Link This issue relates to DM-6179 [ DM-6179 ]
            shupe David Shupe made changes -
            Link This issue is FF-depended by DM-7321 [ DM-7321 ]
            cwang Cindy Wang [X] (Inactive) made changes -
            Sprint SUIT Sprint 2016-9 [ 223 ]
            cwang Cindy Wang [X] (Inactive) made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            cwang Cindy Wang [X] (Inactive) made changes -
            Reviewers David Shupe, Xiuqin Wu [ shupe, xiuqin ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            Permalink
            shupe David Shupe added a comment -

            Review comments in the pull request. There are just a few cases where futurize -2 was too cautious and wrapped some things in list() that should be removed. Overall the cleanup is very nice.

            Show
            shupe David Shupe added a comment - Review comments in the pull request. There are just a few cases where futurize -2 was too cautious and wrapped some things in list() that should be removed. Overall the cleanup is very nice.
            shupe David Shupe made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            cwang Cindy Wang [X] (Inactive) made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            Hide
            Permalink
            cwang Cindy Wang [X] (Inactive) added a comment -

            In order to comply with PEP8 style guide for module's name,
            'Modules should have short, all-lowercase names. Underscores can be used in the module name if it improves
            readability',
            FireflyClient.py is renamed to be firefly_client.py.

            Show
            cwang Cindy Wang [X] (Inactive) added a comment - In order to comply with PEP8 style guide for module's name, 'Modules should have short, all-lowercase names. Underscores can be used in the module name if it improves readability', FireflyClient.py is renamed to be firefly_client.py.
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Summary Adapt FireflyClient to Python 3 Adapt FireflyClient (renamed to firefly_client.py.) to Python 3
            xiuqin Xiuqin Wu [X] (Inactive) made changes -
            Summary Adapt FireflyClient (renamed to firefly_client.py.) to Python 3 Adapt FireflyClient (renamed to firefly_client.py) to Python 3

              People

              Assignee:
              cwang Cindy Wang [X] (Inactive)
              Reporter:
              shupe David Shupe
              Reviewers:
              David Shupe, Xiuqin Wu [X] (Inactive)
              Watchers:
              Cindy Wang [X] (Inactive), David Shupe, Xiuqin Wu [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.