Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7327

Check ngmix works on Python 3

    XMLWordPrintable

    Details

      Description

      Check that ngmix works on python 3.

        Attachments

          Issue Links

            Activity

            Hide
            fred3m Fred Moolekamp added a comment -

            John Swinbank it looks like you created the LSST version of this package. The LSST version is old and does not support python 3 but the current version is supposed to. However, the only thing in the repo is a tarball with a commit from June 27. What is the recommended method for me to update this package?

            Show
            fred3m Fred Moolekamp added a comment - John Swinbank it looks like you created the LSST version of this package. The LSST version is old and does not support python 3 but the current version is supposed to. However, the only thing in the repo is a tarball with a commit from June 27. What is the recommended method for me to update this package?
            Hide
            swinbank John Swinbank added a comment -

            Nothing clever, I think: just drop in a new tarball, demonstrate it passes the tests, merge to master and tag appropriately (I always forget the last bit). This was last done on DM-6724; the commit is trivial.

            Show
            swinbank John Swinbank added a comment - Nothing clever, I think: just drop in a new tarball, demonstrate it passes the tests, merge to master and tag appropriately (I always forget the last bit). This was last done on DM-6724 ; the commit is trivial.
            Hide
            tjenness Tim Jenness added a comment -

            Take a look at how current package. There are no official releases so John Swinbank downloaded a tar file from github for a particular SHA1. See https://github.com/lsst/ngmix/releases for the tagging scheme we are using.

            Show
            tjenness Tim Jenness added a comment - Take a look at how current package. There are no official releases so John Swinbank downloaded a tar file from github for a particular SHA1. See https://github.com/lsst/ngmix/releases for the tagging scheme we are using.
            Hide
            swinbank John Swinbank added a comment -

            demonstrate it passes the tests

            Should clarify that the tests I'm thinking of are those in meas_extensions_ngmix, not in ngmix itself.

            Show
            swinbank John Swinbank added a comment - demonstrate it passes the tests Should clarify that the tests I'm thinking of are those in meas_extensions_ngmix, not in ngmix itself.
            Hide
            fred3m Fred Moolekamp added a comment -

            Upgraded to the latest ngmix and successfully tested meas_extensions_ngmix (DM-7325) on Jenkins with python 2 and 3.

            Show
            fred3m Fred Moolekamp added a comment - Upgraded to the latest ngmix and successfully tested meas_extensions_ngmix ( DM-7325 ) on Jenkins with python 2 and 3.
            Hide
            tjenness Tim Jenness added a comment -

            Looks fine. Remember to add the proper git tag after merging.

            Show
            tjenness Tim Jenness added a comment - Looks fine. Remember to add the proper git tag after merging.
            Hide
            fred3m Fred Moolekamp added a comment -

            I'm not sure what you mean by add the proper git tag. Do you mean just edit the name of the pull request?

            Show
            fred3m Fred Moolekamp added a comment - I'm not sure what you mean by add the proper git tag. Do you mean just edit the name of the pull request?
            Show
            swinbank John Swinbank added a comment - Does https://developer.lsst.io/build-ci/third_party.html#distributing-the-package help?
            Hide
            swinbank John Swinbank added a comment -

            By the way, I think it's fine to only go as far as git push --tags on that page: don't worry about logging in to lsst-dev with special permissions, etc.

            Show
            swinbank John Swinbank added a comment - By the way, I think it's fine to only go as far as git push --tags on that page: don't worry about logging in to lsst-dev with special permissions, etc.
            Hide
            fred3m Fred Moolekamp added a comment -

            Ok, I think that should do it. Thanks for the help.

            Show
            fred3m Fred Moolekamp added a comment - Ok, I think that should do it. Thanks for the help.
            Hide
            tjenness Tim Jenness added a comment -

            In theory you need to run the Jenkins run-rebuild job for ngmix and get the build number and then run-publish with a "current" tag... I can do that.

            Show
            tjenness Tim Jenness added a comment - In theory you need to run the Jenkins run-rebuild job for ngmix and get the build number and then run-publish with a "current" tag... I can do that.
            Hide
            tjenness Tim Jenness added a comment -

            You put the tag on the wrong place. Tags go on master not the ticket branch. The tags allow eups to work out the correct version to report for third party builds. It does not see ticket branches unless you are building that ticket branch. I added a new tag on master.

            Show
            tjenness Tim Jenness added a comment - You put the tag on the wrong place. Tags go on master not the ticket branch. The tags allow eups to work out the correct version to report for third party builds. It does not see ticket branches unless you are building that ticket branch. I added a new tag on master.
            Hide
            fred3m Fred Moolekamp added a comment -

            Thanks. I added the tag before I merged, so I thought it would be included in the merge.

            Show
            fred3m Fred Moolekamp added a comment - Thanks. I added the tag before I merged, so I thought it would be included in the merge.
            Hide
            swinbank John Swinbank added a comment - - edited

            Tim Jenness — You what now? Are you suggesting that the Developer Guide isn't just irrelevant (which was my previous opinion) but actively wrong on the subject of publishing? Are run-rebuild and run-publish actually documented anywhere?

            Show
            swinbank John Swinbank added a comment - - edited Tim Jenness — You what now? Are you suggesting that the Developer Guide isn't just irrelevant (which was my previous opinion) but actively wrong on the subject of publishing? Are run-rebuild and run-publish actually documented anywhere?
            Hide
            tjenness Tim Jenness added a comment -

            I believe the commands in the developer guide to publish a package still work. Frossie Economou uses them to make a release. As I learned only this week, run-publish is used to allow Jenkins to run the publish command for you without having to log in to the server and run-rebuild allows you to do builds on lsst-dev (by running the rebuild command) that you can then publish (using either technique).

            I don't think they are documented anywhere but I might be wrong (ok, I don't know where the documentation is). I can't find the JIRA tickets that implemented the Jenkins features but I assume they are somewhere.

            Show
            tjenness Tim Jenness added a comment - I believe the commands in the developer guide to publish a package still work. Frossie Economou uses them to make a release. As I learned only this week, run-publish is used to allow Jenkins to run the publish command for you without having to log in to the server and run-rebuild allows you to do builds on lsst-dev (by running the rebuild command) that you can then publish (using either technique). I don't think they are documented anywhere but I might be wrong (ok, I don't know where the documentation is). I can't find the JIRA tickets that implemented the Jenkins features but I assume they are somewhere.
            Hide
            frossie Frossie Economou added a comment -

            This is what happens if you use back channels.

            Yes we have a way of publishing via Jenkins (it's related to the automated weekly job) but we're still ironing a couple of things out before it becomes "official".

            Show
            frossie Frossie Economou added a comment - This is what happens if you use back channels. Yes we have a way of publishing via Jenkins (it's related to the automated weekly job) but we're still ironing a couple of things out before it becomes "official".

              People

              Assignee:
              fred3m Fred Moolekamp
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Tim Jenness
              Watchers:
              Fred Moolekamp, Frossie Economou, John Swinbank, Perry Gee, Simon Krughoff, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.