Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7338

Fix-up any code that uses butler.repository

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: butler, pipe_drivers
    • Labels:
      None

      Description

      See https://community.lsst.org/t/access-to-root-in-butler/991
      When running constructBias.py in lsst_apps w_2016_34 I get the error:
      AttributeError in map: 'Butler' object has no attribute 'repository'
      The source of the error is probably
      https://github.com/lsst/pipe_drivers/blob/master/python/lsst/pipe/drivers/constructCalibs.py#L585
      All code that uses butler.repository should be fixed. If that's too much work possibly the ticket could get changed to fix constructCalibs only for now.

        Attachments

          Issue Links

            Activity

            Hide
            aritter Andreas Ritter added a comment -

            Absolutely fine with me

            Show
            aritter Andreas Ritter added a comment - Absolutely fine with me
            Hide
            aritter Andreas Ritter added a comment -

            Removed the butler.repository line

            Show
            aritter Andreas Ritter added a comment - Removed the butler.repository line
            Hide
            rhl Robert Lupton added a comment -

            The fix is fine.

            Did we capture the desire to save this information? It isn't available from the butler for the reasons given, but I think that the script (constructCalibs.py) does know its root – is that right, Paul Price? If so, couldn't we get it from there?

            Show
            rhl Robert Lupton added a comment - The fix is fine. Did we capture the desire to save this information? It isn't available from the butler for the reasons given, but I think that the script (constructCalibs.py) does know its root – is that right, Paul Price ? If so, couldn't we get it from there?
            Hide
            price Paul Price added a comment -

            Note that it's not the butler root directory you want, but the calibs root directory. I think that should be available from the argument parser, but you may have to apply the same defaults logic as in the butler.

            Show
            price Paul Price added a comment - Note that it's not the butler root directory you want, but the calibs root directory. I think that should be available from the argument parser, but you may have to apply the same defaults logic as in the butler.
            Hide
            price Paul Price added a comment -

            This has been merged to master.

            Show
            price Paul Price added a comment - This has been merged to master.

              People

              Assignee:
              aritter Andreas Ritter
              Reporter:
              aritter Andreas Ritter
              Reviewers:
              Robert Lupton
              Watchers:
              Andreas Ritter, John Swinbank, Nate Pease, Paul Price, Robert Lupton
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: