Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7341

Handle lsst.utils.tests dependency better in testExecutables.py

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: utils
    • Labels:
      None

      Description

      The testExecutables.py script that allows py.test to run executable unittests requires lsst.utils.tests. Several packages such as sphgeom explicitly avoid making lsst.utils a dependency. Hence testExecutables.py is unable to reside inside the sphgeom package and py.test is unable to run the executable unittests for now. Figure out which is better:

      1. Make sphgeom depend on lsst.utils
      2. Remove the lsst.utils dependency from testExecutables.py

        Attachments

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment -

            The above discussion looks like it reached a conclusion: nobody seems to object to having sphgeom depend on utils. Work can proceed on DM-7342 on that basis. This is done.

            Show
            swinbank John Swinbank added a comment - The above discussion looks like it reached a conclusion: nobody seems to object to having sphgeom depend on utils. Work can proceed on DM-7342 on that basis. This is done.
            Hide
            tjenness Tim Jenness added a comment -

            Actually I'd rather we didn't. sphgeom is the only dependency that daf_butler has and I've been trying to remove utils from daf_butler. This would negate all that dependency clean up in daf_butler.

            Show
            tjenness Tim Jenness added a comment - Actually I'd rather we didn't. sphgeom is the only dependency that daf_butler has and I've been trying to remove utils from daf_butler. This would negate all that dependency clean up in daf_butler.
            Hide
            swinbank John Swinbank added a comment -

            Why does daf_butler need to be dependency free?

            Show
            swinbank John Swinbank added a comment - Why does daf_butler need to be dependency free?
            Hide
            tjenness Tim Jenness added a comment -

            Because we have this notion that other projects might want to use it and we don't want to make that harder than it should be. We have previously talked about putting sphgeom on pypi.

            Show
            tjenness Tim Jenness added a comment - Because we have this notion that other projects might want to use it and we don't want to make that harder than it should be. We have previously talked about putting sphgeom on pypi.
            Hide
            swinbank John Swinbank added a comment -

            I guess I feel that, as a point of principle, Rubin code ought to be able to use Rubin's own utils package; otherwise, it just feels like we're gratuitously making things harder for ourselves than we need to. If that's a problem for daf_butler, though, maybe reopen this ticket (or file another one), and we can thrash out the issues.

            Show
            swinbank John Swinbank added a comment - I guess I feel that, as a point of principle, Rubin code ought to be able to use Rubin's own utils package; otherwise, it just feels like we're gratuitously making things harder for ourselves than we need to. If that's a problem for daf_butler, though, maybe reopen this ticket (or file another one), and we can thrash out the issues.

              People

              Assignee:
              swinbank John Swinbank
              Reporter:
              vpk24 Vishal Kasliwal [X] (Inactive)
              Reviewers:
              Vishal Kasliwal [X] (Inactive)
              Watchers:
              John Swinbank, Paul Price, Serge Monkewitz, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.