Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7353

Modernize assertions in meas_deblender tests/testEdges.py

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Won't Fix
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_deblender
    • Labels:
      None
    • Story Points:
      1
    • Team:
      Data Release Production

      Description

      The usage of assertTrue to perform array elementwise checks via numpy.any() or numpy.all() is discouraged. They should be replaced with assertions such as assertFloatsEqual etc... from lsst.utils.tests or with assertions from numpy.testing. In the case of the remaining assertTrue statements left in testEdges.py, it is not clear what the expected behavior is. Check the logic in testEdges.py and replace the assertTrue statements.

        Attachments

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment -

            I think the code is clear enough and it's not throwing deprecation warnings. I'm closing this as won't fix.

            Show
            swinbank John Swinbank added a comment - I think the code is clear enough and it's not throwing deprecation warnings. I'm closing this as won't fix.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              vpk24 Vishal Kasliwal [X] (Inactive)
              Watchers:
              John Swinbank, Vishal Kasliwal [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.