Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7357

Decide how to handle tests that plot figures in a py.test environment

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_deblender
    • Labels:
      None
    • Team:
      Architecture

      Description

      Some of the test code in meas_deblender (e.g. testEdges.py, testFitPsf.py etc...) can generate and save figures if the test file is edited to set a plotting flag to True. Decide how this should be handled in a py.test evironment.

        Attachments

          Issue Links

          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7347 Modify meas_deblender tests to support pytest

          • Done
          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Since Tim Jenness has been coordinating the pytest work, I guess this is a question for Architecture. Do reassign if you disagree.

            Show
            swinbank John Swinbank added a comment - Since Tim Jenness has been coordinating the pytest work, I guess this is a question for Architecture. Do reassign if you disagree.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Ok, assuming the display code doesn't take a long time I'd much rather the display code is enabled using a dummy backend (virtualDisplay I think it's called in afw.display, Agg in matplotlib?) with a variable to allow the backend to be tweaked. Anything else is asking for code rot.

            Show
            tjenness Tim Jenness added a comment - Ok, assuming the display code doesn't take a long time I'd much rather the display code is enabled using a dummy backend (virtualDisplay I think it's called in afw.display, Agg in matplotlib?) with a variable to allow the backend to be tweaked. Anything else is asking for code rot.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            I assert that that was a decision. Since this hasn't come up again in 3.5 years, I don't think we need to worry about documentation.

            Show
            swinbank John Swinbank added a comment - I assert that that was a decision. Since this hasn't come up again in 3.5 years, I don't think we need to worry about documentation.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              vpk24 Vishal Kasliwal [X] (Inactive)
              Watchers:
              John Swinbank, Tim Jenness, Vishal Kasliwal [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.