Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7389

Create a public function to reset to the default mask planes

    XMLWordPrintable

    Details

    • Type: Story
    • Status: To Do
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: None
    • Story Points:
      1
    • Sprint:
      AP F23-6 (November)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      Currently the default mask planes are defined in afw/src/image/Mask.cc using

      namespace {
          /*
           * Definition of the default mask bits
           *
           * N.b. this function is in an anonymous namespace, and is invisible to doxygen.  ALL mask
           * planes defined here should be documented with the Mask class in Mask.h
           */
          void
          setInitMaskBits(PTR(detail::MaskDict) dict)
          {
              int i = -1;
              dict->add("BAD", ++i);
              dict->add("SAT", ++i);           // should be SATURATED
              dict->add("INTRP", ++i);         // should be INTERPOLATED
              dict->add("CR", ++i);            //
              dict->add("EDGE", ++i);          //
              dict->add("DETECTED", ++i);      //
              dict->add("DETECTED_NEGATIVE", ++i);
              dict->add("SUSPECT", ++i);
              dict->add("NO_DATA", ++i);
          }
      }
      

      but there is no public method to reset the mask planes to the default. Since the mask plane is a global object this functionality should be available.

        Attachments

          Issue Links

            Activity

            Hide
            fred3m Fred Moolekamp added a comment -

            My recommendation would be to make a "resetMaskPlanesToDefault" method of the Mask<MaskPixelT> object.

            Show
            fred3m Fred Moolekamp added a comment - My recommendation would be to make a "resetMaskPlanesToDefault" method of the Mask<MaskPixelT> object.
            Hide
            swinbank John Swinbank added a comment -

            Reviewed by DM-CCB 2020-02-05. Still seems like a valid request.

            Show
            swinbank John Swinbank added a comment - Reviewed by DM-CCB 2020-02-05. Still seems like a valid request.
            Hide
            Parejkoj John Parejko added a comment -

            Since I'm digging into masks right now, this might be easy to fix.

            Show
            Parejkoj John Parejko added a comment - Since I'm digging into masks right now, this might be easy to fix.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              fred3m Fred Moolekamp
              Watchers:
              Fred Moolekamp, John Parejko, John Swinbank
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:

                  Jenkins

                  No builds found.