# Port obs_monocam to Python 3

## Details

• Type: Story
• Status: Done
• Priority: Major
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
• Templates:
• Story Points:
1
• Sprint:
• Team:

## Activity

Hide
John Parejko added a comment -

This has few dependencies, so I can do it before pipe_*.

Show
John Parejko added a comment - This has few dependencies, so I can do it before pipe_*.
Hide
John Parejko added a comment -

Simon or Tim, can you please review this? monocam doesn't have any tests, so I'm not sure how to check that I broke anything. Also, I accidentally pushed the pep8 cleanups to master.

Show
John Parejko added a comment - Simon or Tim, can you please review this? monocam doesn't have any tests, so I'm not sure how to check that I broke anything. Also, I accidentally pushed the pep8 cleanups to master.
Hide
Tim Jenness added a comment -

Looks good. One minor comment on PR regarding map() versus a list comprehension/generator type thing. I really don't think map() looks at all pythonic.

Show
Tim Jenness added a comment - Looks good. One minor comment on PR regarding map() versus a list comprehension/generator type thing. I really don't think map() looks at all pythonic.
Hide
John Parejko added a comment -

Thanks for the iterator suggestion, Tim Jenness. There are no tests, but a full demo test including obs_monocam passed, so we can assume nothing is new is broken.

Show
John Parejko added a comment - Thanks for the iterator suggestion, Tim Jenness . There are no tests, but a full demo test including obs_monocam passed, so we can assume nothing is new is broken.

## People

• Assignee:
John Parejko
Reporter:
John Swinbank
Reviewers:
Simon Krughoff, Tim Jenness
Watchers:
John Parejko, John Swinbank, Simon Krughoff, Tim Jenness