Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7391

Port obs_monocam to Python 3

    XMLWordPrintable

    Details

      Attachments

        Issue Links

          Activity

          Hide
          Parejkoj John Parejko added a comment -

          This has few dependencies, so I can do it before pipe_*.

          Show
          Parejkoj John Parejko added a comment - This has few dependencies, so I can do it before pipe_*.
          Hide
          Parejkoj John Parejko added a comment -

          Simon or Tim, can you please review this? monocam doesn't have any tests, so I'm not sure how to check that I broke anything. Also, I accidentally pushed the pep8 cleanups to master.

          Show
          Parejkoj John Parejko added a comment - Simon or Tim, can you please review this? monocam doesn't have any tests, so I'm not sure how to check that I broke anything. Also, I accidentally pushed the pep8 cleanups to master.
          Hide
          tjenness Tim Jenness added a comment -

          Looks good. One minor comment on PR regarding `map()` versus a list comprehension/generator type thing. I really don't think `map()` looks at all pythonic.

          Show
          tjenness Tim Jenness added a comment - Looks good. One minor comment on PR regarding `map()` versus a list comprehension/generator type thing. I really don't think `map()` looks at all pythonic.
          Hide
          Parejkoj John Parejko added a comment -

          Thanks for the iterator suggestion, Tim Jenness. There are no tests, but a full demo test including obs_monocam passed, so we can assume nothing is new is broken.

          Show
          Parejkoj John Parejko added a comment - Thanks for the iterator suggestion, Tim Jenness . There are no tests, but a full demo test including obs_monocam passed, so we can assume nothing is new is broken.

            People

            Assignee:
            Parejkoj John Parejko
            Reporter:
            swinbank John Swinbank
            Reviewers:
            Simon Krughoff, Tim Jenness
            Watchers:
            John Parejko, John Swinbank, Simon Krughoff, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.