Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7421

Update processFile to work in modern mid-2016 stack: fix SIP and ->characterizImageTask

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None

      Description

      procesFile needs to be updated to adapt to current Mac OS X SIP workarounds and to migrate from calibrateTask->characterizeImageTask.

        Attachments

          Issue Links

            Activity

            Hide
            wmwood-vasey Michael Wood-Vasey [X] (Inactive) added a comment -

            Robert Lupton I get the following error when running:

            [serenity tmp] processFile.py SN2011gy_A_H_20111115.lsst.fits
            Traceback (most recent call last):
              File "/Users/wmwv/local/lsst/processFile/bin/processFile.py", line 406, in <module>
                displayResults=args.display, verbose=args.verbose)
              File "/Users/wmwv/local/lsst/processFile/bin/processFile.py", line 141, in run
                isrTask.run(exposure, defects=defects)
              File "/Users/wmwv/lsstsw/stack/DarwinX86/pipe_base/12.0-8-gfd1563d+1/python/lsst/pipe/base/timer.py", line 121, in wrapper
                res = func(self, *args, **keyArgs)
              File "/Users/wmwv/lsstsw/stack/DarwinX86/ip_isr/12.0-5-g164de64+1/python/lsst/ip/isr/isrTask.py", line 483, in run
                self.suspectDetection(ccdExposure, amp)
              File "/Users/wmwv/lsstsw/stack/DarwinX86/ip_isr/12.0-5-g164de64+1/python/lsst/ip/isr/isrTask.py", line 705, in suspectDetection
                suspectLevel = amp.getSuspectLevel()
            AttributeError: 'FakeAmp' object has no attribute 'getSuspectLevel'
            

            Show
            wmwood-vasey Michael Wood-Vasey [X] (Inactive) added a comment - Robert Lupton I get the following error when running: [serenity tmp] processFile.py SN2011gy_A_H_20111115.lsst.fits Traceback (most recent call last): File "/Users/wmwv/local/lsst/processFile/bin/processFile.py", line 406, in <module> displayResults=args.display, verbose=args.verbose) File "/Users/wmwv/local/lsst/processFile/bin/processFile.py", line 141, in run isrTask.run(exposure, defects=defects) File "/Users/wmwv/lsstsw/stack/DarwinX86/pipe_base/12.0-8-gfd1563d+1/python/lsst/pipe/base/timer.py", line 121, in wrapper res = func(self, *args, **keyArgs) File "/Users/wmwv/lsstsw/stack/DarwinX86/ip_isr/12.0-5-g164de64+1/python/lsst/ip/isr/isrTask.py", line 483, in run self.suspectDetection(ccdExposure, amp) File "/Users/wmwv/lsstsw/stack/DarwinX86/ip_isr/12.0-5-g164de64+1/python/lsst/ip/isr/isrTask.py", line 705, in suspectDetection suspectLevel = amp.getSuspectLevel() AttributeError: 'FakeAmp' object has no attribute 'getSuspectLevel'
            Hide
            wmwood-vasey Michael Wood-Vasey [X] (Inactive) added a comment -

            Comments on GitHub Pull Request. In brief:

            • One missed calibrateTask->charImageTask.
            • Request improving doc/main.doc to include -display options triggered by the addition of -showPSFs.
            • Request for documentation of an if False

            Code works well in conjunction with the update to ip_isr (which was the source of comment above). Produces reasonable results and runs on test image I had sitting around.

            Show
            wmwood-vasey Michael Wood-Vasey [X] (Inactive) added a comment - Comments on GitHub Pull Request. In brief: One missed calibrateTask -> charImageTask . Request improving doc/main.doc to include - display options triggered by the addition of -showPSFs . Request for documentation of an if False Code works well in conjunction with the update to ip_isr (which was the source of comment above). Produces reasonable results and runs on test image I had sitting around.
            Hide
            wmwood-vasey Michael Wood-Vasey [X] (Inactive) added a comment -

            Robert Lupton updated in response to Pull Request review.
            and
            Merged to master.

            Show
            wmwood-vasey Michael Wood-Vasey [X] (Inactive) added a comment - Robert Lupton updated in response to Pull Request review. and Merged to master.

              People

              Assignee:
              rhl Robert Lupton
              Reporter:
              wmwood-vasey Michael Wood-Vasey [X] (Inactive)
              Reviewers:
              Michael Wood-Vasey [X] (Inactive)
              Watchers:
              Michael Wood-Vasey [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins Builds

                  No builds found.