Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7442

Write unit tests for DCR template generation code

    Details

    • Story Points:
      8
    • Sprint:
      Alert Production F16 - 9, Alert Production F16 - 10
    • Team:
      Alert Production

      Description

      DM-5697 and DM-6249 created code that generates DCR-matched template images for image subtraction. These functions should have unit tests.

        Attachments

          Issue Links

            Activity

            Hide
            sullivan Ian Sullivan added a comment -

            The main program with the unit tests that need review is python/dcr_template.py . I apologize for the size of the repository, I had to provide test data to someone in a hurry in a while back, and added several large data files to the repository. You will probably also need to have lsst_sims set up to run the tests.

            Show
            sullivan Ian Sullivan added a comment - The main program with the unit tests that need review is python/dcr_template.py . I apologize for the size of the repository, I had to provide test data to someone in a hurry in a while back, and added several large data files to the repository. You will probably also need to have lsst_sims set up to run the tests.
            Hide
            rowen Russell Owen added a comment -

            This looks much nicer. I did leave some comments on github.

            My main concern is that many of the tests compare results against previously saved results. If you don't have a strong a priori sense of what values to expect then that may be most appropriate thing to do, and it's certainly useful. But I hope you can eventually figure out more tests that rely on values that you determine in a more direct fashion.

            Show
            rowen Russell Owen added a comment - This looks much nicer. I did leave some comments on github. My main concern is that many of the tests compare results against previously saved results. If you don't have a strong a priori sense of what values to expect then that may be most appropriate thing to do, and it's certainly useful. But I hope you can eventually figure out more tests that rely on values that you determine in a more direct fashion.
            Hide
            sullivan Ian Sullivan added a comment -

            Thanks for the review! All of the tests that use saved results call functions that generate large numbers of values, and I wasn't sure how else to check those without losing information (say, by comparing the sum). I would be happy to talk about better types of tests for these cases!

            Show
            sullivan Ian Sullivan added a comment - Thanks for the review! All of the tests that use saved results call functions that generate large numbers of values, and I wasn't sure how else to check those without losing information (say, by comparing the sum). I would be happy to talk about better types of tests for these cases!

              People

              • Assignee:
                sullivan Ian Sullivan
                Reporter:
                sullivan Ian Sullivan
                Reviewers:
                Russell Owen
                Watchers:
                Ian Sullivan, Russell Owen
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: