Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7450

Update coding standard to reflect non-executable tests (RFC-215)

    Details

    • Story Points:
      0.5
    • Sprint:
      Arch 2019-07-29
    • Team:
      Architecture

      Description

      Following the discussion at RFC-215, we need to update the developer guide to reflect that python tests should not be executable, nor have a shabang at the top. This is probably a few sentences to the python testing portion part of the dev. guide, possibly in a new subsection at the end.

        Attachments

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment -

            I closed the outdated PR at https://github.com/lsst-dm/dm_dev_guide/pull/121. I hope that Jonathan Sick will pick this up and produce a modified version when he has time.

            Show
            swinbank John Swinbank added a comment - I closed the outdated PR at https://github.com/lsst-dm/dm_dev_guide/pull/121 . I hope that Jonathan Sick will pick this up and produce a modified version when he has time.
            Hide
            tjenness Tim Jenness added a comment -

            I've resurrected this ticket and put a tweaked version of Maria Patterson [X]'s text in a new PR.

            Show
            tjenness Tim Jenness added a comment - I've resurrected this ticket and put a tweaked version of Maria Patterson [X] 's text in a new PR.
            Hide
            tjenness Tim Jenness added a comment -

            Are people happy with my rewording?

            Show
            tjenness Tim Jenness added a comment - Are people happy with my rewording?
            Hide
            jsick Jonathan Sick added a comment -

            I added comments about the placement of this material in the PR.

            Show
            jsick Jonathan Sick added a comment - I added comments about the placement of this material in the PR.
            Hide
            ktl Kian-Tat Lim added a comment -

            I approve this change.

            Show
            ktl Kian-Tat Lim added a comment - I approve this change.

              People

              • Assignee:
                tjenness Tim Jenness
                Reporter:
                Parejkoj John Parejko
                Reviewers:
                Kian-Tat Lim
                Watchers:
                John Parejko, John Swinbank, Jonathan Sick, Kian-Tat Lim, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel