Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7458

Cannot add base_GaussianFlux to the list of default plugins in DipoleFitTask.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ip_diffim
    • Labels:
      None

      Description

      The DipoleFitTask plugin in ip_diffim currently registers a number of default measurement tasks. However, if base_GaussianFlux is registered, the following error is produced:

      Alias for 'slot_Shape_flag' must be defined before initializing 'base_GaussianFlux' plugin.

      {0}

      lsst::pex::exceptions::LogicError: 'Alias for 'slot_Shape_flag' must be defined before initializing 'base_GaussianFlux' plugin.'

      Track this down and fix it so that we can add base_GaussianFlux to the default list.

        Attachments

          Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-7376 Failure to identify location of clear supernova in a subtraction

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            reiss David Reiss added a comment -

            See Jim Bosch's comment on the github discussion for DM-7376. This should be an easy fix.

            Show
            reiss David Reiss added a comment - See Jim Bosch 's comment on the github discussion for DM-7376 . This should be an easy fix.
            Hide
            Permalink
            reiss David Reiss added a comment -

            Hi Colin, would you review this minor change to DipoleFitTask in ip_diffim? I wanted to add a number of measurements plugins (as default) to run alongside dipole measurement – this will be useful for future debugging. I currently am not sure which measurement methods can correctly handle negative sources, but this will be figured out soon, and the ones that can't will be either removed or fixed.

            This did not break any tests on jenkins:
            https://ci.lsst.codes/job/stack-os-matrix/15652/

            Show
            reiss David Reiss added a comment - Hi Colin, would you review this minor change to DipoleFitTask in ip_diffim? I wanted to add a number of measurements plugins (as default) to run alongside dipole measurement – this will be useful for future debugging. I currently am not sure which measurement methods can correctly handle negative sources, but this will be figured out soon, and the ones that can't will be either removed or fixed. This did not break any tests on jenkins: https://ci.lsst.codes/job/stack-os-matrix/15652/
            Hide
            Permalink
            ctslater Colin Slater added a comment -

            Looks good. Shapes might be good to look at for false positive rejection.

            Show
            ctslater Colin Slater added a comment - Looks good. Shapes might be good to look at for false positive rejection.
            Hide
            Permalink
            reiss David Reiss added a comment -

            Merged.

            Show
            reiss David Reiss added a comment - Merged.

              People

              Assignee:
              reiss David Reiss
              Reporter:
              reiss David Reiss
              Reviewers:
              Colin Slater
              Watchers:
              Colin Slater, David Reiss
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.