Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7461

afw test suite fails in the absence of afwdata

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None
    • Story Points:
      0.5
    • Team:
      Architecture

      Description

      Running a fresh build of afw master on os x fails on two unit tests. One is in testExecutables.py and is related to not finding AFWData. On my system AFWData is not installed and the test should be skipped, but is still run. The other is DM-7474.

        Attachments

          Issue Links

          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7207 Modify afw tests to support pytest

          • Done
          is triggering

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7474 Numerical issue in afw's ChebyshevBoundedFieldTestCase

          • Done
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. DM-609 afw unit tests not built unless afwdata available

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7390 Improve tests highly sensitive to random seeds

          • Won't Fix

            Activity

            Ascending order - Click to sort in descending order
            18 older comments
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Regarding testExecutables, I think the simplest thing to do is just to wrap the getPackageDir calls in the two tests and have them return if afwdata is missing. We can keep all the test disabling stuff in the SConscript file but I don't think testExecutables has a means of monitoring skip counts in executables.

            Show
            tjenness Tim Jenness added a comment - Regarding testExecutables , I think the simplest thing to do is just to wrap the getPackageDir calls in the two tests and have them return if afwdata is missing. We can keep all the test disabling stuff in the SConscript file but I don't think testExecutables has a means of monitoring skip counts in executables.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            I'll give my theory a quick try.

            Show
            tjenness Tim Jenness added a comment - I'll give my theory a quick try.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            John Swinbank can you take a quick look? I just wrap the calls to getPackageDir so that the tests will work when testExecutables runs them or if someone uses the command line. The SConscript logic still applies.

            Show
            tjenness Tim Jenness added a comment - John Swinbank can you take a quick look? I just wrap the calls to getPackageDir so that the tests will work when testExecutables runs them or if someone uses the command line. The SConscript logic still applies.
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Does "AFWDATA" really need block caps? Other than that, I can't find anything to complain about. How disappointing.

            Show
            swinbank John Swinbank added a comment - Does "AFWDATA" really need block caps? Other than that, I can't find anything to complain about. How disappointing.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Merged (and edited as requested). J Matt Peterson [X] this should help your conda problem.

            Show
            tjenness Tim Jenness added a comment - Merged (and edited as requested). J Matt Peterson [X] this should help your conda problem.

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              nlust Nate Lust
              Reviewers:
              John Swinbank
              Watchers:
              Fred Moolekamp, J Matt Peterson [X] (Inactive), John Swinbank, Nate Lust, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.