Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7477

Increase mask plane size to 32 bits

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Story Points:
      12
    • Sprint:
      DRP F17-1, DRP F17-2
    • Team:
      Data Release Production

      Description

      As per RFC-25, increase the Mask plane bit count from 16 to 32, which should hopefully just be (but probably won't be) a matter of modifying a typedef.

        Attachments

          Issue Links

            Activity

            Hide
            price Paul Price added a comment -

            This is great. The only change I would insist upon is that in python we need to be able to write Mask.staticMethod(...) instead of Mask[MaskPixel].staticMethod(...) — the python user shouldn't need to know that MaskPixel even exists. I've pushed some changes to branch u/price/DM-7477 of afw and utils that should allow this behaviour.

            Why MaskX instead of MaskI, when we use I for int32 in other contexts?

            Show
            price Paul Price added a comment - This is great. The only change I would insist upon is that in python we need to be able to write Mask.staticMethod(...) instead of Mask [MaskPixel] .staticMethod(...) — the python user shouldn't need to know that MaskPixel even exists. I've pushed some changes to branch u/price/ DM-7477 of afw and utils that should allow this behaviour. Why MaskX instead of MaskI , when we use I for int32 in other contexts?
            Hide
            price Paul Price added a comment -

            Oh, and we need a test for reading legacy HeavyFootprint.

            Show
            price Paul Price added a comment - Oh, and we need a test for reading legacy HeavyFootprint .
            Hide
            nlust Nate Lust added a comment -

            MaskX was chosen to be just a place holder, and decouple it from the underlying type, as they type is unimportant, and may change.

            Show
            nlust Nate Lust added a comment - MaskX was chosen to be just a place holder, and decouple it from the underlying type, as they type is unimportant, and may change.
            Hide
            nlust Nate Lust added a comment -

            merged all to master

            Show
            nlust Nate Lust added a comment - merged all to master
            Hide
            xiuqin Xiuqin Wu [X] (Inactive) added a comment -

            Nate LustCould you provide a FIST image with the 32bits mask? I want to test that Firefly could display the mask layer correctly. Thank you!

            Show
            xiuqin Xiuqin Wu [X] (Inactive) added a comment - Nate Lust Could you provide a FIST image with the 32bits mask? I want to test that Firefly could display the mask layer correctly. Thank you!

              People

              • Assignee:
                nlust Nate Lust
                Reporter:
                jbosch Jim Bosch
                Reviewers:
                Paul Price
                Watchers:
                Jim Bosch, John Swinbank, Nate Lust, Paul Price, Robert Lupton, Russell Owen, Xiuqin Wu [X] (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel