Details
-
Type:
Improvement
-
Status: Won't Fix
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: Continuous Integration, lsstsw
-
Labels:None
-
Epic Link:
-
Team:SQuaRE
Description
When starting a Jenkins run a user can easily mis-type the desired branch, at which point a normal master run is conducted with no warning. This is dangerous, since a user may think a ticket branch has passed CI when it has not been tested.
To prevent this silent failure mode, I suggest that Jenkins require that for each specified branch, at least one package it has been asked to build must contain that branch.
One way to implement this is to modify lsstsw to detect whether any package was seen with each specified branch, and fail after the git checkout stage if not.
Attachments
Issue Links
- relates to
-
DM-12160 Rebuild should complain if a ref is not found
- Done
Activity
The relevant code is here: https://github.com/lsst/lsst_build/blob/master/python/lsst/ci/prepare.py#L691
This was completed in DM-12160 by patching lsst_build to fail if no refs could be found.
I think this is a great idea. I think the only way to implement this is to modify lsst-build. This should then trigger the failure which lsstsw would report. The lsstsw failure would then be caught by Jenkins (I think what I'm saying is that Jenkins is a distraction in this discussion).