Details

    • Type: Story
    • Status: Done
    • Priority: Major
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_subaru
    • Labels:
      None
    • Templates:
    • Story Points:
      0.5
    • Sprint:
      DRP F16-4
    • Team:
      Data Release Production

      Description

      Port of HSC-1419.

        Issue Links

          Activity

          Hide
          price Paul Price added a comment -

          Lauren MacArthur, would you mind having a look at this? Bob Armstrong already reviewed it on the HSC side, but there were some conflicts in the cherry-pick.

          price@price-laptop:~/LSST/obs/subaru (tickets/DM-7510=) $ git sub
          commit ff0ccdaec844f1ddbaaf23a186cd94943e17f435
          Author: Paul Price <price@astro.princeton.edu>
          Date:   Wed Aug 31 14:33:50 2016 -0400
           
              add support for HSC-R2 filter
              
              Color terms provided by Yasuda-san.
           
           config/hsc/colorterms.py             | 2 ++
           config/hsc/filterMap.py              | 2 +-
           config/hsc/mergeCoaddDetections.py   | 5 ++---
           config/hsc/mergeCoaddMeasurements.py | 5 ++---
           python/lsst/obs/hsc/hscMapper.py     | 2 ++
           5 files changed, 9 insertions(+), 7 deletions(-)
          

          Show
          price Paul Price added a comment - Lauren MacArthur , would you mind having a look at this? Bob Armstrong already reviewed it on the HSC side, but there were some conflicts in the cherry-pick. price@price-laptop:~/LSST/obs/subaru (tickets/DM-7510=) $ git sub commit ff0ccdaec844f1ddbaaf23a186cd94943e17f435 Author: Paul Price <price@astro.princeton.edu> Date: Wed Aug 31 14:33:50 2016 -0400   add support for HSC-R2 filter Color terms provided by Yasuda-san.   config/hsc/colorterms.py | 2 ++ config/hsc/filterMap.py | 2 +- config/hsc/mergeCoaddDetections.py | 5 ++--- config/hsc/mergeCoaddMeasurements.py | 5 ++--- python/lsst/obs/hsc/hscMapper.py | 2 ++ 5 files changed, 9 insertions(+), 7 deletions(-)
          Hide
          lauren Lauren MacArthur added a comment -

          Sure thing. Any idea why the branch doesn't show up in Jira?

          Show
          lauren Lauren MacArthur added a comment - Sure thing. Any idea why the branch doesn't show up in Jira?
          Hide
          price Paul Price added a comment -

          I made a PR, and it's showing up now.

          Show
          price Paul Price added a comment - I made a PR, and it's showing up now.
          Hide
          lauren Lauren MacArthur added a comment -

          Is there any HSC-R2 data anywhere on tiger I could test this on? There's nothing in /tigress/HSC/HSC/registry.sqlite3.

          Otherwise, it looks like you could add r2 to the list here:
          https://github.com/lsst/obs_subaru/blob/master/tests/testColorterms.py#L73

          Show
          lauren Lauren MacArthur added a comment - Is there any HSC-R2 data anywhere on tiger I could test this on? There's nothing in /tigress/HSC/HSC/registry.sqlite3 . Otherwise, it looks like you could add r2 to the list here: https://github.com/lsst/obs_subaru/blob/master/tests/testColorterms.py#L73
          Hide
          price Paul Price added a comment -

          I don't have any R2 data that I'm aware of yet.

          I added r2 to the test.

          Show
          price Paul Price added a comment - I don't have any R2 data that I'm aware of yet. I added r2 to the test.
          Hide
          price Paul Price added a comment -
          Show
          price Paul Price added a comment - Jenkins passed .
          Hide
          lauren Lauren MacArthur added a comment -

          Ok. I don't think it can matter in this case, but in general would it be a good idea to include ci_hsc in your Jenkins build when you've made edits in obs_subaru?

          Good to go.

          Show
          lauren Lauren MacArthur added a comment - Ok. I don't think it can matter in this case, but in general would it be a good idea to include ci_hsc in your Jenkins build when you've made edits in obs_subaru ? Good to go.
          Hide
          price Paul Price added a comment -

          Thanks Lauren. I think I had already tested through ci_hsc previously, so when I expanded the test I only went through obs_subaru.

          Merged to master.

          Show
          price Paul Price added a comment - Thanks Lauren. I think I had already tested through ci_hsc previously, so when I expanded the test I only went through obs_subaru. Merged to master.

            People

            • Assignee:
              price Paul Price
              Reporter:
              price Paul Price
              Reviewers:
              Lauren MacArthur
              Watchers:
              Lauren MacArthur, Paul Price
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development

                  Agile