Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7523

obs_sdss test should not print outside of test

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_sdss
    • Labels:
      None
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      DRP F16-4
    • Team:
      Data Release Production

      Description

      In DM-7346 the testSelectSdssImages.py test was modified to skip if a server was unavailable but the reason for the lack of availability was printed to standard error at the module level. This print is not captured by pytest (it only captures test output). The reason has to be moved inside the skip message.

        Attachments

          Issue Links

          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7346 Modify obs_sdss to support pytest

          • Done
          is triggering

          Improvement - An improvement or enhancement to an existing feature or task. DM-7608 testSelectSdssImages.py broken: "noConnectionStr" not defined

          • Done

            Activity

            Ascending order - Click to sort in descending order
            8 older comments
            Hide
            Permalink
            fred3m Fred Moolekamp added a comment -

            Ah, I didn't realize that Josh's comment was made while assigning me as the reviewer. I usually look at the comments view instead of all.

            Show
            fred3m Fred Moolekamp added a comment - Ah, I didn't realize that Josh's comment was made while assigning me as the reviewer. I usually look at the comments view instead of all.
            Hide
            Permalink
            tjenness Tim Jenness added a comment - - edited

            Did you get the review request email?

            Show
            tjenness Tim Jenness added a comment - - edited Did you get the review request email?
            Hide
            Permalink
            fred3m Fred Moolekamp added a comment -

            Yes, but I find the emails a bit hard to read, so I usually just click the link to open the ticket and read the comments in JIRA. So I thought that Josh had asked me to review the ticket before he assigned me and might have thought that I was ignoring him (the timestamp in JIRA for his comment is just "yesterday"). I just wanted to let him know that I wasn't.

            Show
            fred3m Fred Moolekamp added a comment - Yes, but I find the emails a bit hard to read, so I usually just click the link to open the ticket and read the comments in JIRA. So I thought that Josh had asked me to review the ticket before he assigned me and might have thought that I was ignoring him (the timestamp in JIRA for his comment is just "yesterday"). I just wanted to let him know that I wasn't.
            Hide
            Permalink
            jmeyers314 Joshua Meyers added a comment -

            There's no need to have the removal of the import in a separate commit so I would squash the two commits together before merging.

            Will do. I wasn't sure how strictly the "atomicize your commits" culture was here, but I admit that removing the import is pretty trivial.

            but I find the emails a bit hard to read

            No problem. I'll try to error on the side of more @mentions.

            Thanks for taking a look Fred Moolekamp!

            Show
            jmeyers314 Joshua Meyers added a comment - There's no need to have the removal of the import in a separate commit so I would squash the two commits together before merging. Will do. I wasn't sure how strictly the "atomicize your commits" culture was here, but I admit that removing the import is pretty trivial. but I find the emails a bit hard to read No problem. I'll try to error on the side of more @mentions. Thanks for taking a look Fred Moolekamp !
            Hide
            Permalink
            fred3m Fred Moolekamp added a comment -

            No problem. I've only been here just over a month so I am not the best person to take stringent coding advice from.

            As for the comment, that was my bad not realizing that the email assigning me as reviewer and asking me to review were the same email, so I thought I missed a message.

            Show
            fred3m Fred Moolekamp added a comment - No problem. I've only been here just over a month so I am not the best person to take stringent coding advice from. As for the comment, that was my bad not realizing that the email assigning me as reviewer and asking me to review were the same email, so I thought I missed a message.

              People

              Assignee:
              jmeyers314 Joshua Meyers
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Fred Moolekamp
              Watchers:
              Fred Moolekamp, John Swinbank, Joshua Meyers, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.