Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7533

astrometry_net log is not controllable from the command line interface

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_astrom
    • Labels:
      None

      Description

      The external logs from astrometry_net (https://github.com/dstndstn/astrometry.net) is now passed through to lsst.log with the logger name "meas.astrom.astrometry_net". But unlike other internal logger components, the astrometry_net log is not controllable from the command line intercae. I suspect a bug in this commit.

        Attachments

          Issue Links

            Activity

            Hide
            hchiang2 Hsin-Fang Chiang added a comment -

            Typically a c++ macro from lsst.log should be used. But in this case, the location information of the logging statements in the original astrometry_net source code is wanted, not that in the SWIG-generated file. Using the macro would record the location information from the SWIG-generated file astrometry_net_wrap.cc. So everything done inside the macros should be done in astrometry_net.i an_log_callback, including checking whether the log is enabled for a level.

            Show
            hchiang2 Hsin-Fang Chiang added a comment - Typically a c++ macro from lsst.log should be used. But in this case, the location information of the logging statements in the original astrometry_net source code is wanted, not that in the SWIG-generated file. Using the macro would record the location information from the SWIG-generated file astrometry_net_wrap.cc. So everything done inside the macros should be done in astrometry_net.i an_log_callback, including checking whether the log is enabled for a level.
            Hide
            hchiang2 Hsin-Fang Chiang added a comment -

            May you please review the few-line change in meas_astrom?

            Show
            hchiang2 Hsin-Fang Chiang added a comment - May you please review the few-line change in meas_astrom?
            Hide
            hchiang2 Hsin-Fang Chiang added a comment -

            Jenkins is being run and meas.astrom.astrometry_net should not be so chatty on its DEBUG messages in the stack demo as in the master (e.g., near the bottom of the output in master)

            Also I just noticed my ticket branch has fallen behind master. I'll make sure to rebase and run Jenkins again.

            Show
            hchiang2 Hsin-Fang Chiang added a comment - Jenkins is being run and meas.astrom.astrometry_net should not be so chatty on its DEBUG messages in the stack demo as in the master (e.g., near the bottom of the output in master ) Also I just noticed my ticket branch has fallen behind master. I'll make sure to rebase and run Jenkins again.
            Hide
            price Paul Price added a comment -

            Looking at the patch only, I didn't understand why you're implementing the log threshold manually rather than letting the logger do it. I think I understand that on looking at the commit message. Maybe a short comment in the code is warranted? Or maybe not.

            Show
            price Paul Price added a comment - Looking at the patch only, I didn't understand why you're implementing the log threshold manually rather than letting the logger do it. I think I understand that on looking at the commit message. Maybe a short comment in the code is warranted? Or maybe not.
            Hide
            hchiang2 Hsin-Fang Chiang added a comment -

            Thank you for reviewing. I added a comment in the code. Running another Jenkins on the rebased version before merging it.

            Show
            hchiang2 Hsin-Fang Chiang added a comment - Thank you for reviewing. I added a comment in the code. Running another Jenkins on the rebased version before merging it.
            Hide
            hchiang2 Hsin-Fang Chiang added a comment -

            Merged

            Show
            hchiang2 Hsin-Fang Chiang added a comment - Merged

              People

              Assignee:
              hchiang2 Hsin-Fang Chiang
              Reporter:
              hchiang2 Hsin-Fang Chiang
              Reviewers:
              Paul Price
              Watchers:
              Hsin-Fang Chiang, Paul Price
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  CI Builds

                  No builds found.