Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7552

Add (t)csh and zsh alternatives to lsstsw bin/setup.sh

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None

      Description

      The LSST software build tool setup script (in bin/setup.sh) currently assumes that the user is using a bash shell. Running this command from zsh doesn't generate any visible warnings, but since zsh doesn't know what to do with $BASH_SOURCE, it just leaves it blank, resulting in $LSSTSW being (silently!) set to the parent directory of the right directory instead of the right directory.

      I think it should be pretty easy to just make a separate setup script for zsh (and (t)csh for that matter too), similar to what's already in $LSSTSW/eups/current/bin/. As far as I can tell, only the setup script needs to be duplicated, since the rest (e.g., rebuild) start with a bash she-bang to change the shell anyway.

      Part of this issue should also be to modify the instructions at https://developer.lsst.io/build-ci/lsstsw.html to reflect the possibility of different shells.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            Sorry. Had forgotten to mark the review complete. In my rush I made a comment without closing it. One of you has to decide to own this ticket and merge the code. Simon Krughoff turned it into an Alert Production ticket so he should sort out who's closing it at his end.

            Show
            tjenness Tim Jenness added a comment - Sorry. Had forgotten to mark the review complete. In my rush I made a comment without closing it. One of you has to decide to own this ticket and merge the code. Simon Krughoff turned it into an Alert Production ticket so he should sort out who's closing it at his end.
            Hide
            krughoff Simon Krughoff added a comment -

            Yes. I'll have Krzysztof Findeisen take care of it.

            Show
            krughoff Simon Krughoff added a comment - Yes. I'll have Krzysztof Findeisen take care of it.
            Hide
            krzys Krzysztof Findeisen added a comment -

            The documentation changes in lsst-dm/dm_dev_guide have not been reviewed; is it ok to just merge those as-is?

            Show
            krzys Krzysztof Findeisen added a comment - The documentation changes in lsst-dm/dm_dev_guide have not been reviewed; is it ok to just merge those as-is?
            Hide
            tjenness Tim Jenness added a comment -

            Dev guide stuff is fine.

            Show
            tjenness Tim Jenness added a comment - Dev guide stuff is fine.
            Hide
            krzys Krzysztof Findeisen added a comment -

            Code and documentation both merged.

            Show
            krzys Krzysztof Findeisen added a comment - Code and documentation both merged.

              People

              Assignee:
              krzys Krzysztof Findeisen
              Reporter:
              jmeyers314 Joshua Meyers
              Reviewers:
              Tim Jenness
              Watchers:
              Colin Slater, John Swinbank, Jonathan Sick, Joshua Meyers, Krzysztof Findeisen, Lauren MacArthur, Simon Krughoff, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.