Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7556

Remove lsst_ci from demo in Jenkins and add to default product list

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Please add lsst_ci to the default product list (along with lsst_distrib and lsst_sims) to make it clear that lsst_ci is going to be built by default. Revert the "Skip Demo" behavior to the old behavior prior to DM-5433, of running the stack demo or not running the stack demo (which only requires lsst_apps to be built). The current situation has caused much confusion.

      This ticket was initially a request to make it clear in the text associated with "Skip Demo" that choosing the demo will cause lsst_ci to be built.

        Attachments

          Issue Links

          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-14806 convert stack demo to be a regular eups product

          • Done
          is duplicated by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8360 Please document how to avoid building lsst_ci with Jenkins

          • Invalid
          is triggered by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-5433 Add lsst_ci as default build target for Jenkins

          • Done
          relates to

          Bug - A problem which impairs or prevents the functions of the product. DM-8158 Dev Guide does not say how to run Python 3 integration tests

          • Invalid

            Activity

            Ascending order - Click to sort in descending order
            13 older comments
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            This was the commit that added lsst_ci to the demo: https://github.com/lsst-sqre/sandbox-jenkins-demo/pull/23/commits/2356e4f95210e23f2911816552e587b28c232f22

            It looks like that commit can't be reverted because it has unrelated changes included.

            Show
            tjenness Tim Jenness added a comment - This was the commit that added lsst_ci to the demo: https://github.com/lsst-sqre/sandbox-jenkins-demo/pull/23/commits/2356e4f95210e23f2911816552e587b28c232f22 It looks like that commit can't be reverted because it has unrelated changes included.
            Hide
            Permalink
            jhoblitt Joshua Hoblitt added a comment -

            Note that the files touched in DM-5433 don't even exist anymore.

            Show
            jhoblitt Joshua Hoblitt added a comment - Note that the files touched in DM-5433 don't even exist anymore.
            Hide
            Permalink
            frossie Frossie Economou added a comment -

            Sorry, I am confused as to why this is assigned to Jonathan, assigning back to Josh.

            I agree the current behaviour is very confusing.

            We're about to do some major overhaul of both the CI user interface and the jobs list, but in the meanwhile Josh, just add some text to the UI so instead of "Skip demo?" it says "Skip demo and lsst_ci?"

            Show
            frossie Frossie Economou added a comment - Sorry, I am confused as to why this is assigned to Jonathan, assigning back to Josh. I agree the current behaviour is very confusing. We're about to do some major overhaul of both the CI user interface and the jobs list, but in the meanwhile Josh, just add some text to the UI so instead of "Skip demo?" it says "Skip demo and lsst_ci?"
            Hide
            Permalink
            jhoblitt Joshua Hoblitt added a comment -

            Per a few discussions on slack over the last couple of days, the way forward seems to be unlocked now in that the demo, which is now (also) a proper eups product, be added to lsst_ci, that lsst_ci be added to the default products list, and the SKIP_DEMO button be removed completely.

            Show
            jhoblitt Joshua Hoblitt added a comment - Per a few discussions on slack over the last couple of days, the way forward seems to be unlocked now in that the demo, which is now (also) a proper eups product, be added to lsst_ci , that lsst_ci be added to the default products list, and the SKIP_DEMO button be removed completely.
            Hide
            Permalink
            jhoblitt Joshua Hoblitt added a comment -

            Summary of changes implimented:

            • The SKIP_DEMO checkbox has been removed from various jenkins jobs
            • the runManifestDemo.sh demo driver script has been removed from the ci-scripts
            • the env vars used by jenkins/ci-scripts to configure a build were overhauled, including adding a prefix of LSST_ to most env vars.
            • the hard-coded product list (previously) of lsst_distrib, that was in a surprising number of jenkins jobs has been centralized to jenkins-dm-jobs:/etc/scipipe/build_matrix.yaml
            • miscellaneous cleanups
            Show
            jhoblitt Joshua Hoblitt added a comment - Summary of changes implimented: The SKIP_DEMO checkbox has been removed from various jenkins jobs the runManifestDemo.sh demo driver script has been removed from the ci-scripts the env vars used by jenkins/ ci-scripts to configure a build were overhauled, including adding a prefix of LSST_ to most env vars. the hard-coded product list (previously) of lsst_distrib , that was in a surprising number of jenkins jobs has been centralized to jenkins-dm-jobs:/etc/scipipe/build_matrix.yaml miscellaneous cleanups

              People

              Assignee:
              jhoblitt Joshua Hoblitt
              Reporter:
              frossie Frossie Economou
              Watchers:
              Colin Slater, Frossie Economou, Gabriele Comoretto [X] (Inactive), Jonathan Sick, Joshua Hoblitt, Michael Wood-Vasey, Russell Owen, Simon Krughoff, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.