What would you like the description to read? The deps pulled in are only what is needed to run said tests.

See for example Michael Wood-Vasey's comment on DM-5433: https://jira.lsstcorp.org/browse/DM-5433?focusedCommentId=46294&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-46294

It currently says:

Do not run the demo after all packages have completed building.

but people have no real idea that your definition of demo now includes lsst_ci. We had huge confusion over this during the Python 3 porting extravaganza where jobs were failing all over the place because they forgot to skip the demo. Changing it to:

Do not run the demo after all packages have completed building and do not include lsst_ci in the product list.

or something, would help mental triggers.

Historically, the demo did not pull extra packages into the build, it just failed if lsst_apps was not available, but that was at least after all the requested packages built. Conceptually, DM-5433 made a huge difference to the list of products being built. Before that ticket: the system built what you asked for regardless of the demo flag. After that ticket you got many extra packages built. It would have been clearer to add lsst_ci to the list of default packages in the PRODUCT entry along with lsst_sims and lsst_distrib.

I agree with Frossie that run-rebuild should only ever build the packages you are requesting.

"It would have been clearer to add lsst_ci to the list of default packages in the PRODUCT entry along with lsst_sims and lsst_distrib."

Seconding this. Much better solution than having some complicated text to describe the demo checkbox.

I agree with Tim Jenness and Colin Slater (as you have heard me say before). It would be a huge help to all developers if the product list showed the actual list of products passed to lsstsw's "rebuild" command.

+1

Michael Wood-Vasey is that +1 to change the wording or +1 to add lsst_ci to the product list?

+1 to add `lsst_ci` to the product list and not have separate logic in the demo.

We need to in general re-think the demo and its invocation. We also need to think and plan out how to run more extensive tests as part of lsst_ci. But I suggest that at this point there are significant practical gains for clarity to devs to defer those large discussions, and implement lsst_ci as an explicit package to be built.

Why is it taking so long to sort this out? All we want is lsst_ci to be added as an explicit package in the default list and for the demo to be just the demo.

Joshua Hoblitt assigned it to me as a learning opportunity but I've been completely loaded this cycle and haven't gotten to this.

Ah, I was wondering why Joshua Hoblitt was no longer the assignee...

I would like to update the description and title of this ticket to reflect the strong feeling in the comments that the real fix here is to remove lsst_ci from the default demo. When this ticket was going to be a five minute tweak to the UI it made sense to keep it simple but it's not clear we are going to get the wording change and we would all rather get the real fix done. I won't make the change immediately, but give time for people to jump in and tell me to create a new ticket.

As threatened last week I have updated this ticket to reflect the consensus that we wish lsst_ci to be added to the default product list along with lsst_distrib and lsst_sims and for DM-5433 to be reverted so that demo means demo. I imagine you may want to change the Assignee.

This was the commit that added lsst_ci to the demo: https://github.com/lsst-sqre/sandbox-jenkins-demo/pull/23/commits/2356e4f95210e23f2911816552e587b28c232f22

It looks like that commit can't be reverted because it has unrelated changes included.

Note that the files touched in DM-5433 don't even exist anymore.

Sorry, I am confused as to why this is assigned to Jonathan, assigning back to Josh.

I agree the current behaviour is very confusing.

We're about to do some major overhaul of both the CI user interface and the jobs list, but in the meanwhile Josh, just add some text to the UI so instead of "Skip demo?" it says "Skip demo and lsst_ci?"

Per a few discussions on slack over the last couple of days, the way forward seems to be unlocked now in that the demo, which is now (also) a proper eups product, be added to lsst_ci, that lsst_ci be added to the default products list, and the SKIP_DEMO button be removed completely.

Summary of changes implimented:

• The SKIP_DEMO checkbox has been removed from various jenkins jobs
• the runManifestDemo.sh demo driver script has been removed from the ci-scripts
• the env vars used by jenkins/ci-scripts to configure a build were overhauled, including adding a prefix of LSST_ to most env vars.
• the hard-coded product list (previously) of lsst_distrib, that was in a surprising number of jenkins jobs has been centralized to jenkins-dm-jobs:/etc/scipipe/build_matrix.yaml
• miscellaneous cleanups