Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7565

Add bbox to ExposureInfo

    XMLWordPrintable

Details

    • Story
    • Status: To Do
    • Resolution: Unresolved
    • None
    • afw

    Description

      Part of RFC-199 is to add bounding box support to ExposureInfo, e.g. getBBox. This ticket is to implement that feature. See also DM-5503 which implements the rest of the RFC.

      Attachments

        Issue Links

          Activity

            No builds found.
            rowen Russell Owen created issue -
            rowen Russell Owen made changes -
            Field Original Value New Value
            Link This issue is triggered by RFC-199 [ RFC-199 ]
            rowen Russell Owen made changes -
            Link This issue relates to DM-5503 [ DM-5503 ]
            rowen Russell Owen made changes -
            Story Points 10
            rowen Russell Owen made changes -
            Epic Link DM-5501 [ 23333 ]
            rowen Russell Owen made changes -
            Sprint Alert Production S17 - 2 [ 361 ]
            rowen Russell Owen made changes -
            Team Alert Production [ 10300 ]
            Parejkoj John Parejko made changes -
            Link This issue relates to DM-9153 [ DM-9153 ]
            krughoff Simon Krughoff (Inactive) made changes -
            Sprint Alert Production S17 - 2 [ 361 ] Alert Production S17 - 2, Alert Production S17 - 3 [ 361, 605 ]
            krughoff Simon Krughoff (Inactive) made changes -
            Rank Ranked higher
            rowen Russell Owen made changes -
            Sprint Alert Production S17 - 2, Alert Production S17 - 3 [ 361, 605 ] Alert Production S17 - 2 [ 361 ]
            rowen Russell Owen made changes -
            Sprint Alert Production S17 - 2 [ 361 ] Alert Production S17 - 2, Alert Production S17 - 4 [ 361, 610 ]
            rowen Russell Owen made changes -
            Rank Ranked higher
            rowen Russell Owen made changes -
            Rank Ranked lower
            rowen Russell Owen made changes -
            Sprint Alert Production S17 - 2, Alert Production S17 - 4 [ 361, 610 ] Alert Production S17 - 2 [ 361 ]
            rowen Russell Owen made changes -
            Rank Ranked lower
            rowen Russell Owen added a comment -

            Based on this discussion indexing image objects (especially jbosch's comment) I am inclined to put this on hold until we figure out what the AstroPy project is going to do with NDData. We might as well match AstroPy if we can, and there's no rush.

            rowen Russell Owen added a comment - Based on this discussion indexing image objects (especially jbosch 's comment ) I am inclined to put this on hold until we figure out what the AstroPy project is going to do with NDData . We might as well match AstroPy if we can, and there's no rush.

            Unfortunately, this is starting to block Parejkoj. I think we should go ahead and do this and figure out how to fit it in with the NDData world when that settles down (maybe as part of DM-10769).

            krughoff Simon Krughoff (Inactive) added a comment - Unfortunately, this is starting to block Parejkoj . I think we should go ahead and do this and figure out how to fit it in with the NDData world when that settles down (maybe as part of DM-10769 ).
            jbosch Jim Bosch added a comment -

            I'm surprised this can be a blocker, though I can imagine it might be very convenient - can't we just have signatures that pass a Box along with the ExposureInfo where we need to?

            That said, I'm not at all opposed to this, but I do think RFC-343 needs to be taken care of first, or it will be way too easy to get the ExposureInfo bounding box out of sync with the Exposure it's associated with.

            jbosch Jim Bosch added a comment - I'm surprised this can be a blocker, though I can imagine it might be very convenient - can't we just have signatures that pass a Box along with the ExposureInfo where we need to? That said, I'm not at all opposed to this, but I do think RFC-343 needs to be taken care of first, or it will be way too easy to get the ExposureInfo bounding box out of sync with the Exposure it's associated with.
            krughoff Simon Krughoff (Inactive) made changes -
            Link This issue is blocked by RFC-343 [ RFC-343 ]
            swinbank John Swinbank made changes -
            Epic Link DM-5501 [ 23333 ] DM-10774 [ 32740 ]
            swinbank John Swinbank made changes -
            Epic Link DM-10774 [ 32740 ] DM-11798 [ 34281 ]
            swinbank John Swinbank made changes -
            Epic Link DM-11798 [ 34281 ] DM-12728 [ 36327 ]
            rowen Russell Owen made changes -
            Link This issue is blocked by DM-10781 [ DM-10781 ]
            rowen Russell Owen made changes -
            Link This issue is blocked by RFC-343 [ RFC-343 ]
            swinbank John Swinbank made changes -
            Epic Link DM-12728 [ 36327 ] DM-14447 [ 80385 ]

            We're discussing this as I write in our sprint planning meeting. The suggestion has come up that this work should simply be abandoned, as we're not getting traction on it and it's never going to be high priority. Thoughts? jbosch?

            swinbank John Swinbank added a comment - We're discussing this as I write in our sprint planning meeting. The suggestion has come up that this work should simply be abandoned, as we're not getting traction on it and it's never going to be high priority. Thoughts? jbosch ?
            swinbank John Swinbank made changes -
            Risk Score 0
            jbosch Jim Bosch added a comment -

            Abandoning this is fine with me.  I think we should generally think of ExposureInfo as an implementation detail, not a first class object, and I think the original impetus for this ticket was thinking of it as a first-class object.

            jbosch Jim Bosch added a comment - Abandoning this is fine with me.  I think we should generally think of ExposureInfo as an implementation detail, not a first class object, and I think the original impetus for this ticket was thinking of it as a first-class object.

            The rationale for keeping ExposureInfo as a first class object (possibly with a new name) is to have a place to hold all of the non-pixel metadata (which would include BBox). This is related to the meta object that astropy's NDData had, but with more structure. Having an assortment of different objects hanging off of the Exposure itself makes for a more complicated Exposure/NDData API.

            Parejkoj John Parejko added a comment - The rationale for keeping ExposureInfo as a first class object (possibly with a new name) is to have a place to hold all of the non-pixel metadata (which would include BBox). This is related to the meta object that astropy's NDData had, but with more structure. Having an assortment of different objects hanging off of the Exposure itself makes for a more complicated Exposure / NDData API.
            jbosch Jim Bosch added a comment -

            I would prefer for that metadata object to be ExposureRecord, assuming we can't find a way to unify them, so we can more easily handle sequences of them.

            jbosch Jim Bosch added a comment - I would prefer for that metadata object to be ExposureRecord , assuming we can't find a way to unify them, so we can more easily handle sequences of them.
            rowen Russell Owen made changes -
            Assignee Russell Owen [ rowen ]
            swinbank John Swinbank made changes -
            Epic Link DM-14447 [ 80385 ] DM-16722 [ 235355 ]
            swinbank John Swinbank made changes -
            Epic Link DM-16722 [ 235355 ] DM-17887 [ 240317 ]
            swinbank John Swinbank made changes -
            Epic Link DM-17887 [ 240317 ] DM-19979 [ 307530 ]
            swinbank John Swinbank made changes -
            Epic Link DM-19979 [ 307530 ] DM-21441 [ 423048 ]
            swinbank John Swinbank made changes -
            Epic Link DM-21441 [ 423048 ] DM-22484 [ 427311 ]
            swinbank John Swinbank made changes -
            Epic Link DM-22484 [ 427311 ] DM-24339 [ 433026 ]
            swinbank John Swinbank made changes -
            Epic Link DM-24339 [ 433026 ] DM-25139 [ 435257 ]
            swinbank John Swinbank made changes -
            Epic Link DM-25139 [ 435257 ] DM-26810 [ 439762 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-26810 [ 439762 ] DM-27906 [ 442554 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-27906 [ 442554 ] DM-29214 [ 459218 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-29214 [ 459218 ] DM-30436 [ 504824 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-30436 [ 504824 ] DM-30501 [ 510159 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-30501 [ 510159 ] DM-30502 [ 510160 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-30502 [ 510160 ] DM-30506 [ 510172 ]
            horvat Nikolina Horvat made changes -
            Epic Link DM-30506 [ 510172 ] DM-34931 [ 1598492 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-34931 [ 1598492 ] DM-36006 [ 1997396 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-36006 [ 1997396 ] DM-36522 [ 2254239 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-36522 [ 2254239 ] DM-36523 [ 2254240 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-36523 [ 2254240 ] DM-36524 [ 2254243 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-36524 [ 2254243 ] DM-36525 [ 2254245 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-36525 [ 2254245 ] DM-36538 [ 2254390 ]

            People

              Unassigned Unassigned
              rowen Russell Owen
              Jim Bosch, John Parejko, John Swinbank, Russell Owen, Simon Krughoff (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:

                Jenkins

                  No builds found.