Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7578

Create obs_base and make obs_test work with it

    XMLWordPrintable

    Details

    • Story Points:
      8
    • Epic Link:
    • Sprint:
      Alert Production F16 - 9, Alert Production F16 - 10
    • Team:
      Alert Production

      Description

      To support broad testing of obs packages, with minimal configuration, we will add an obs_base package that all obs packages will depend on. It will contain a test suite for them to derive from, plus frameworks for other modules (e.g. makeSomeCameraRepository.py).

      obs_test will be the demo for how this new module works. Implementation details will be worked out along the way.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7915 Rename daf_butlerUtils to obs_base

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-7909 mapper.validate should raise ValueError on non-integer visits

          • Won't Fix

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-228 Rename obs_test to obs_example

          • Withdrawn

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-230 Rename daf_butlerUtils to obs_base

          • Implemented

            Activity

            Ascending order - Click to sort in descending order
            6 older comments
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Updated obs_base and obs_test package for review, Paul! I believe I've answered most of the concerns you had in the previous (now deleted review). Please take another look.

            Also, there is some partial work started for decam in DM-7730, which is reflected in the details of the design above, but the decam tests are going to need a decam expert to dig into them in more detail before they're ready.

            Show
            Parejkoj John Parejko added a comment - Updated obs_base and obs_test package for review, Paul! I believe I've answered most of the concerns you had in the previous (now deleted review). Please take another look. Also, there is some partial work started for decam in DM-7730 , which is reflected in the details of the design above, but the decam tests are going to need a decam expert to dig into them in more detail before they're ready.
            Hide
            Permalink
            price Paul Price added a comment -

            Review completed on GitHub PR. I have a bunch of small comments, but nothing substantial.

            Show
            price Paul Price added a comment - Review completed on GitHub PR. I have a bunch of small comments, but nothing substantial.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Finally got Jenkins to pass (rogue obs_decam branch of this ticket that I had to empty): https://ci.lsst.codes/job/stack-os-matrix/17770/

            I believe I've answered all of your concerns, Paul. I'm going to merge obs_test and obs_base now.

            Show
            Parejkoj John Parejko added a comment - Finally got Jenkins to pass (rogue obs_decam branch of this ticket that I had to empty): https://ci.lsst.codes/job/stack-os-matrix/17770/ I believe I've answered all of your concerns, Paul. I'm going to merge obs_test and obs_base now.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Merged obs_base and obs_test with new tests.

            Show
            Parejkoj John Parejko added a comment - Merged obs_base and obs_test with new tests.
            Hide
            Permalink
            price Paul Price added a comment -

            Great job, John.

            Show
            price Paul Price added a comment - Great job, John.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Paul Price
              Watchers:
              Colin Slater, John Parejko, Paul Price, Russell Owen, Simon Krughoff, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.