Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7585

lsstsw deploy script uses unportable tty option

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: lsstsw
    • Labels:
      None

      Description

      In DM-4345 deploy was patched to check for a tty but the --quiet option was used. This option is not supported on OS X. -s seems to be more portable.

        Attachments

          Issue Links

          is triggered by

          Improvement - An improvement or enhancement to an existing feature or task. DM-4345 OSX CI/jenkins build slaves

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            The OS X man page actually suggests using

            test -t 0

            and says -s is deprecated.

            Show
            tjenness Tim Jenness added a comment - The OS X man page actually suggests using test -t 0 and says -s is deprecated.
            Hide
            Permalink
            jhoblitt Joshua Hoblitt added a comment - - edited

            test does seem like the safest option as it is covered by posix: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html

            Show
            jhoblitt Joshua Hoblitt added a comment - - edited test does seem like the safest option as it is covered by posix: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Trivial change looks fine. Does it still work on Jenkins okay? It's a bit strange that both of the deploy-blead OSX jobs failed in the same way.

            Show
            tjenness Tim Jenness added a comment - Trivial change looks fine. Does it still work on Jenkins okay? It's a bit strange that both of the deploy-blead OSX jobs failed in the same way.
            Hide
            Permalink
            jhoblitt Joshua Hoblitt added a comment -

            I think the osx bleed failures are OK. That package diff was intended to be a canary that the package list has fallen behind on the current published versions. The same failure is happening in other PRs: https://travis-ci.org/lsst/lsstsw/builds/158331936

            Show
            jhoblitt Joshua Hoblitt added a comment - I think the osx bleed failures are OK. That package diff was intended to be a canary that the package list has fallen behind on the current published versions. The same failure is happening in other PRs: https://travis-ci.org/lsst/lsstsw/builds/158331936
            Hide
            Permalink
            jhoblitt Joshua Hoblitt added a comment -

            The fix has been merged.

            Show
            jhoblitt Joshua Hoblitt added a comment - The fix has been merged.

              People

              Assignee:
              jhoblitt Joshua Hoblitt
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Tim Jenness
              Watchers:
              John Parejko, Joshua Hoblitt, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.