In DM-4345 deploy was patched to check for a tty but the --quiet option was used. This option is not supported on OS X. -s seems to be more portable.
OSX CI/jenkins build slaves
The OS X man page actually suggests using
test -t 0
and says -s is deprecated.
test does seem like the safest option as it is covered by posix: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html
Trivial change looks fine. Does it still work on Jenkins okay? It's a bit strange that both of the deploy-blead OSX jobs failed in the same way.
I think the osx bleed failures are OK. That package diff was intended to be a canary that the package list has fallen behind on the current published versions. The same failure is happening in other PRs: https://travis-ci.org/lsst/lsstsw/builds/158331936
The fix has been merged.