Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7608

testSelectSdssImages.py broken: "noConnectionStr" not defined

    XMLWordPrintable

Details

    Description

      A recent change to testSelectSdssImages.py broke the test for those who could connect to the database. The symptom is:

      NameError: name 'noConnectionStr' is not defined
      

      and is self descriptive. I have a fix ready to go.

      Attachments

        Issue Links

          Activity

            rowen Russell Owen added a comment -

            One line fix

            rowen Russell Owen added a comment - One line fix
            Parejkoj John Parejko added a comment -

            I'd just lift noConnectStr from out of the except: block to the top level, but your fix also works. Your call if you want to change that or just merge.

            Parejkoj John Parejko added a comment - I'd just lift noConnectStr from out of the except: block to the top level, but your fix also works. Your call if you want to change that or just merge.
            rowen Russell Owen added a comment -

            Your suggestion reduces repetition but at the cost of a string claiming the connection failed even if it succeeded. I'd rather use my solution. Another option is to treat the string as the thing to test (and get rid of noConnection), but I'm not keen on "anything is a bool", so I'll leave it as is.

            rowen Russell Owen added a comment - Your suggestion reduces repetition but at the cost of a string claiming the connection failed even if it succeeded. I'd rather use my solution. Another option is to treat the string as the thing to test (and get rid of noConnection ), but I'm not keen on "anything is a bool", so I'll leave it as is.

            People

              rowen Russell Owen
              rowen Russell Owen
              John Parejko
              Joshua Meyers, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.