Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7608

testSelectSdssImages.py broken: "noConnectionStr" not defined

    XMLWordPrintable

    Details

      Description

      A recent change to testSelectSdssImages.py broke the test for those who could connect to the database. The symptom is:

      NameError: name 'noConnectionStr' is not defined

      and is self descriptive. I have a fix ready to go.

        Attachments

          Issue Links

          is triggered by

          Bug - A problem which impairs or prevents the functions of the product. DM-7523 obs_sdss test should not print outside of test

          • Done

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            rowen Russell Owen created issue -
            rowen Russell Owen made changes -
            Field Original Value New Value
            Epic Link DM-7362 [ 26448 ]
            Hide
            Permalink
            rowen Russell Owen added a comment -

            One line fix

            Show
            rowen Russell Owen added a comment - One line fix
            rowen Russell Owen made changes -
            Reviewers John Parejko [ parejkoj ]
            Status To Do [ 10001 ] In Review [ 10004 ]
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            I'd just lift noConnectStr from out of the except: block to the top level, but your fix also works. Your call if you want to change that or just merge.

            Show
            Parejkoj John Parejko added a comment - I'd just lift noConnectStr from out of the except: block to the top level, but your fix also works. Your call if you want to change that or just merge.
            Parejkoj John Parejko made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Your suggestion reduces repetition but at the cost of a string claiming the connection failed even if it succeeded. I'd rather use my solution. Another option is to treat the string as the thing to test (and get rid of noConnection), but I'm not keen on "anything is a bool", so I'll leave it as is.

            Show
            rowen Russell Owen added a comment - Your suggestion reduces repetition but at the cost of a string claiming the connection failed even if it succeeded. I'd rather use my solution. Another option is to treat the string as the thing to test (and get rid of noConnection ), but I'm not keen on "anything is a bool", so I'll leave it as is.
            rowen Russell Owen made changes -
            Watchers John Parejko, Russell Owen [ John Parejko, Russell Owen ] Joshua Meyers, Russell Owen [ Joshua Meyers, Russell Owen ]
            rowen Russell Owen made changes -
            Link This issue is triggered by DM-7523 [ DM-7523 ]
            rowen Russell Owen made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              John Parejko
              Watchers:
              Joshua Meyers, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.