# Modernize tests in datarel to support pytest

XMLWordPrintable

## Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
None
• Story Points:
0.1
• Team:
Architecture

## Description

Update testGetPsf.py to work with pytest.

## Activity

Hide
John Swinbank added a comment -

I believe datarel only exists until DM-2948 can be closed, and therefore assume this test isn't actually testing anything useful. Maybe easier to simply remove it?

Show
John Swinbank added a comment - I believe datarel only exists until DM-2948 can be closed, and therefore assume this test isn't actually testing anything useful. Maybe easier to simply remove it?
Hide
Tim Jenness added a comment -

It was a trivial change so I fixed the test.

Show
Tim Jenness added a comment - It was a trivial change so I fixed the test.
Hide
John Swinbank added a comment -

Since this code is deprecated and slated for removal, and since there are hundreds of lines of (mainly automated) changes here, I don't think it's worth going through them all and reviewing them carefully. A quick scan indicates that we're now overflowing the line-length limit in several places: perhaps fix that before merging?

Show
John Swinbank added a comment - Since this code is deprecated and slated for removal, and since there are hundreds of lines of (mainly automated) changes here, I don't think it's worth going through them all and reviewing them carefully. A quick scan indicates that we're now overflowing the line-length limit in several places: perhaps fix that before merging?
Hide
Tim Jenness added a comment -

Show

## People

• Assignee:
Tim Jenness
Reporter:
Tim Jenness
Reviewers:
John Swinbank
Watchers:
John Swinbank, Tim Jenness