Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7623

Modernize tests in datarel to support pytest

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • datarel
    • None
    • 0.1
    • Architecture

    Description

      Update testGetPsf.py to work with pytest.

      Attachments

        Issue Links

          Activity

            I believe datarel only exists until DM-2948 can be closed, and therefore assume this test isn't actually testing anything useful. Maybe easier to simply remove it?

            swinbank John Swinbank added a comment - I believe datarel only exists until DM-2948 can be closed, and therefore assume this test isn't actually testing anything useful. Maybe easier to simply remove it?
            tjenness Tim Jenness added a comment -

            It was a trivial change so I fixed the test.

            tjenness Tim Jenness added a comment - It was a trivial change so I fixed the test.

            Since this code is deprecated and slated for removal, and since there are hundreds of lines of (mainly automated) changes here, I don't think it's worth going through them all and reviewing them carefully. A quick scan indicates that we're now overflowing the line-length limit in several places: perhaps fix that before merging?

            swinbank John Swinbank added a comment - Since this code is deprecated and slated for removal, and since there are hundreds of lines of (mainly automated) changes here, I don't think it's worth going through them all and reviewing them carefully. A quick scan indicates that we're now overflowing the line-length limit in several places: perhaps fix that before merging?
            tjenness Tim Jenness added a comment -

            Requested changes made.

            tjenness Tim Jenness added a comment - Requested changes made.

            People

              tjenness Tim Jenness
              tjenness Tim Jenness
              John Swinbank
              John Swinbank, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.