Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7623

Modernize tests in datarel to support pytest

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: datarel
    • Labels:
      None
    • Story Points:
      0.1
    • Team:
      Architecture

      Description

      Update testGetPsf.py to work with pytest.

        Attachments

          Issue Links

          blocks

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. DM-7600 Pytest and Flake8 integration with CI and sconsUtils

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-2948 Remove explicit buildbot dependency on datarel

          • Done
          mentioned in

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            tjenness Tim Jenness created issue -
            tjenness Tim Jenness made changes -
            Field Original Value New Value
            Remote Link This issue links to "Page (Confluence)" [ 14304 ]
            tjenness Tim Jenness made changes -
            Assignee Kian-Tat Lim [ ktl ]
            tjenness Tim Jenness made changes -
            Link This issue blocks DM-7600 [ DM-7600 ]
            tjenness Tim Jenness made changes -
            Remote Link This issue links to "Page (Confluence)" [ 14304 ] This issue links to "Page (Confluence)" [ 14304 ]
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            I believe datarel only exists until DM-2948 can be closed, and therefore assume this test isn't actually testing anything useful. Maybe easier to simply remove it?

            Show
            swinbank John Swinbank added a comment - I believe datarel only exists until DM-2948 can be closed, and therefore assume this test isn't actually testing anything useful. Maybe easier to simply remove it?
            tjenness Tim Jenness made changes -
            Assignee Tim Jenness [ tjenness ]
            tjenness Tim Jenness made changes -
            Story Points 0.1
            Team Architecture [ 10304 ]
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            It was a trivial change so I fixed the test.

            Show
            tjenness Tim Jenness added a comment - It was a trivial change so I fixed the test.
            tjenness Tim Jenness made changes -
            Reviewers John Swinbank [ swinbank ]
            Status To Do [ 10001 ] In Review [ 10004 ]
            tjenness Tim Jenness made changes -
            Link This issue relates to DM-2948 [ DM-2948 ]
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            Since this code is deprecated and slated for removal, and since there are hundreds of lines of (mainly automated) changes here, I don't think it's worth going through them all and reviewing them carefully. A quick scan indicates that we're now overflowing the line-length limit in several places: perhaps fix that before merging?

            Show
            swinbank John Swinbank added a comment - Since this code is deprecated and slated for removal, and since there are hundreds of lines of (mainly automated) changes here, I don't think it's worth going through them all and reviewing them carefully. A quick scan indicates that we're now overflowing the line-length limit in several places: perhaps fix that before merging?
            swinbank John Swinbank made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Requested changes made.

            Show
            tjenness Tim Jenness added a comment - Requested changes made.
            tjenness Tim Jenness made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              John Swinbank
              Watchers:
              John Swinbank, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.