Details

    • Type: Story
    • Status: Done
    • Priority: Major
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_algorithms
    • Labels:
      None
    • Templates:
    • Story Points:
      4
    • Team:
      Process Middleware

      Description

      Switch the logging/tracing in C++ from lsst.pex.logging to lsst.log in meas_algorithms

        Issue Links

          Activity

          Hide
          hchiang2 Hsin-Fang Chiang added a comment -

          Passed Jenkins: https://ci.lsst.codes/job/stack-os-matrix/label=centos-7,python=py2/16415//console

          Besides meas_algorithms, minor edits in ip_isr, meas_extensions_shapeHSM, meas_extensions_psfex, meas_modelfit are done to make Jenkins happy.

          Show
          hchiang2 Hsin-Fang Chiang added a comment - Passed Jenkins: https://ci.lsst.codes/job/stack-os-matrix/label=centos-7,python=py2/16415//console Besides meas_algorithms, minor edits in ip_isr, meas_extensions_shapeHSM, meas_extensions_psfex, meas_modelfit are done to make Jenkins happy.
          Hide
          hchiang2 Hsin-Fang Chiang added a comment -

          John Parejko may you please review this?

          Documentations of the logging usage have just been added to our Developer Guide at: https://developer.lsst.io/coding/logging.html
          If you see anything that should be made clearer I'd appreciate feedbacks.

          meas_algorithms/tests/testCr.py is a cute example of fine-level tracing (the maximum number of tracing levels used I've found so far in the current stack!). In debugging, one can adjust the verbosity number in logUtils.traceSetAt("algorithms.CR", NUMBER) without recompiling and see more or fewer messages from the CR code (src/CR.cc). From RFC-203 I understand that is one main use case of tracing.

          Show
          hchiang2 Hsin-Fang Chiang added a comment - John Parejko may you please review this? Documentations of the logging usage have just been added to our Developer Guide at: https://developer.lsst.io/coding/logging.html If you see anything that should be made clearer I'd appreciate feedbacks. meas_algorithms/tests/testCr.py is a cute example of fine-level tracing (the maximum number of tracing levels used I've found so far in the current stack!). In debugging, one can adjust the verbosity number in logUtils.traceSetAt("algorithms.CR", NUMBER) without recompiling and see more or fewer messages from the CR code (src/CR.cc). From RFC-203 I understand that is one main use case of tracing.
          Hide
          Parejkoj John Parejko added a comment -

          I made pull requests for the other packages: you'll probably want to go subscribe to those, otherwise you won't see what I wrote (very minor comments).

          Show
          Parejkoj John Parejko added a comment - I made pull requests for the other packages: you'll probably want to go subscribe to those, otherwise you won't see what I wrote (very minor comments).
          Hide
          Parejkoj John Parejko added a comment -

          Just a handful of comments. Nice work: I think the new logging interface is cleaner.

          Show
          Parejkoj John Parejko added a comment - Just a handful of comments. Nice work: I think the new logging interface is cleaner.
          Hide
          hchiang2 Hsin-Fang Chiang added a comment -

          Thanks a lot for your speedy review!

          Merged after another Jenkins including ci_hsc.

          Show
          hchiang2 Hsin-Fang Chiang added a comment - Thanks a lot for your speedy review! Merged after another Jenkins including ci_hsc.
          Show
          hchiang2 Hsin-Fang Chiang added a comment - - edited This also cleared the pex_logging dependency in meas_extensions_shapeHSM, ip_isr, meas_extensions_psfex confirmed by: https://ci.lsst.codes/job/stack-os-matrix/label=centos-7,python=py2/16433//console https://ci.lsst.codes/job/stack-os-matrix/label=centos-7,python=py2/16439//console https://ci.lsst.codes/job/stack-os-matrix/label=centos-7,python=py2/16440//console

            People

            • Assignee:
              hchiang2 Hsin-Fang Chiang
              Reporter:
              hchiang2 Hsin-Fang Chiang
              Reviewers:
              John Parejko
              Watchers:
              Hsin-Fang Chiang, John Parejko
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development