Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7684

Clean up ip_diffim tests

    XMLWordPrintable

Details

    • Story
    • Status: To Do
    • Resolution: Unresolved
    • None
    • ip_diffim
    • None

    Description

      During review of DM-7297 (porting ip_diffim to py3), we found the examples and tests needed more attention. Some specifics to start:

      • There are three test files in the examples and it's unclear why (`compareKernelTypes`, `compareLambdaTypes`, and `jackknifeResampleSpatialKernel`)
      • The `compareLambdaTypes` example uses `afwdata` but should catch the exception if `afwdata` is missing and then skip the tests. It also has old-style tests with `suite.`
      • There are lots of try/except/else blocks in `testBasisLists` (and other tests too!) that would be cleaner using a `with self.assertRaises(Exception)` syntax. tjenness says: "I think this entire construct exists to convert an 'E' test error into an 'F' test failure ... I would be inclined to remove all the boilerplate and let any problems trigger an 'E' because these commands are all meant to work and an 'E' is still something that needs to be fixed. There's a reason why there is no `self.assertDoesNotRaise()` method in `unittest`."

      Attachments

        Issue Links

          Activity

            No builds found.
            mrawls Meredith Rawls created issue -
            mrawls Meredith Rawls made changes -
            Field Original Value New Value
            Link This issue relates to DM-7297 [ DM-7297 ]

            I've pushed a possible fix for item 3 (for just testBasisLists) to DM-7297.

            Parejkoj John Parejko added a comment - I've pushed a possible fix for item 3 (for just testBasisLists) to DM-7297 .
            yusra Yusra AlSayyad made changes -
            Assignee Simon Krughoff [ krughoff ] John Swinbank [ swinbank ]
            swinbank John Swinbank made changes -
            Epic Link DM-16714 [ 235322 ]
            swinbank John Swinbank made changes -
            Labels SciencePipelines
            swinbank John Swinbank made changes -
            Assignee John Swinbank [ swinbank ]
            swinbank John Swinbank made changes -
            Assignee Gabor Kovacs [ gkovacs ]
            swinbank John Swinbank made changes -
            Story Points 6
            swinbank John Swinbank made changes -
            Sprint AP S19-4 [ 832 ]
            swinbank John Swinbank made changes -
            Epic Link DM-16714 [ 235322 ] DM-17994 [ 240550 ]
            swinbank John Swinbank made changes -
            Sprint AP S19-4 [ 832 ] AP S19-4, AP S19-5 [ 832, 833 ]
            swinbank John Swinbank made changes -
            Sprint AP S19-4, AP S19-5 [ 832, 833 ] AP S19-4 [ 832 ]
            swinbank John Swinbank made changes -
            Epic Link DM-17994 [ 240550 ] DM-19977 [ 307523 ]
            swinbank John Swinbank made changes -
            Epic Link DM-19977 [ 307523 ] DM-21444 [ 423051 ]
            swinbank John Swinbank made changes -
            Epic Link DM-21444 [ 423051 ] DM-22635 [ 427744 ]
            swinbank John Swinbank made changes -
            Epic Link DM-22635 [ 427744 ] DM-24342 [ 433029 ]
            swinbank John Swinbank made changes -
            Epic Link DM-24342 [ 433029 ] DM-25144 [ 435262 ]
            swinbank John Swinbank made changes -
            Epic Link DM-25144 [ 435262 ] DM-26804 [ 439756 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-26804 [ 439756 ] DM-27910 [ 442603 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-27910 [ 442603 ] DM-29210 [ 459212 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-29210 [ 459212 ] DM-30435 [ 504823 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-30435 [ 504823 ] DM-30503 [ 510162 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-30503 [ 510162 ] DM-30504 [ 510170 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-30504 [ 510170 ] DM-30505 [ 510171 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-30505 [ 510171 ] DM-34935 [ 1598553 ]
            Parejkoj John Parejko made changes -
            Link This issue relates to RFC-870 [ RFC-870 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-34935 [ 1598553 ] DM-35986 [ 1991281 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-35986 [ 1991281 ] DM-36518 [ 2254224 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-36518 [ 2254224 ] DM-36519 [ 2254228 ]
            Parejkoj John Parejko made changes -
            Description During review of DM-7297 (porting ip_diffim to py3), we found the examples and tests needed more attention. Some specifics to start:
            * There are three test files in the examples and it's unclear why (`compareKernelTypes`, `compareLambdaTypes`, and `jackknifeResampleSpatialKernel`)
            * The `compareLambdaTypes` example uses `afwdata` but should catch the exception if `afwdata` is missing and then skip the tests. It also has old-style tests with `suite.`
            * There are lots of try/except/else blocks in `testBasisLists` (and other tests too!) that would be cleaner using a `with self.assertRaises(Exception)` syntax. tjenness says: "I think this entire construct exists to convert an 'E' test error into an 'F' test failure ... I would be inclined to remove all the boilerplate and let any problems trigger an 'E' because these commands are all meant to work and an 'E' is still something that needs to be fixed. There's a reason why there is no `self.assertDoesNotRaise()` method in `unittest`."
            During review of DM-7297 (porting ip_diffim to py3), we found the examples and tests needed more attention. Some specifics to start:
            * There are three test files in the examples and it's unclear why (`compareKernelTypes`, `compareLambdaTypes`, and `jackknifeResampleSpatialKernel`)
            * -The `compareLambdaTypes` example uses `afwdata` but should catch the exception if `afwdata` is missing and then skip the tests. It also has old-style tests with `suite.`-
            * There are lots of try/except/else blocks in `testBasisLists` (and other tests too!) that would be cleaner using a `with self.assertRaises(Exception)` syntax. tjenness says: "I think this entire construct exists to convert an 'E' test error into an 'F' test failure ... I would be inclined to remove all the boilerplate and let any problems trigger an 'E' because these commands are all meant to work and an 'E' is still something that needs to be fixed. There's a reason why there is no `self.assertDoesNotRaise()` method in `unittest`."
            Parejkoj John Parejko made changes -
            Summary Clean up ip_diffim examples and tests Clean up ip_diffim tests
            sullivan Ian Sullivan made changes -
            Epic Link DM-36519 [ 2254228 ] DM-36520 [ 2254232 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-36520 [ 2254232 ] DM-36521 [ 2254235 ]
            sullivan Ian Sullivan made changes -
            Epic Link DM-36521 [ 2254235 ] DM-36534 [ 2254365 ]

            People

              gkovacs Gabor Kovacs [X] (Inactive)
              mrawls Meredith Rawls
              John Parejko, Meredith Rawls, Simon Krughoff (Inactive), Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:

                Jenkins

                  No builds found.