Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7688

Invalid queries cause segmentation fault in newUserQuery()

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Team:
      Data Access and Database

      Description

      Invalid queries cause segmentation fault in UserQueryFactory::newUserQuery() due to executive not being created on when invalidSession is false, but the following call to create a UserQuerySelect object wants a valid executive.

      The constructor for UserQuerySelect is registering the query, which is probably more than the constructor should do. Also, we probably should not be registering invalid queries.

        Attachments

          Issue Links

            Activity

            Hide
            jgates John Gates added a comment - - edited

            I put in a quick fix, but perhaps the constructor for UserQuerySelect does too much and the call to register it should be moved outside. The fix bypasses the problem line if _executive is null.

            Show
            jgates John Gates added a comment - - edited I put in a quick fix, but perhaps the constructor for UserQuerySelect does too much and the call to register it should be moved outside. The fix bypasses the problem line if _executive is null.
            Hide
            fritzm Fritz Mueller added a comment -

            "Temporary" fix has sufficed for four years, and any further improvements will be addressed in onging query coverage work.

            Show
            fritzm Fritz Mueller added a comment - "Temporary" fix has sufficed for four years, and any further improvements will be addressed in onging query coverage work.

              People

              • Assignee:
                Unassigned
                Reporter:
                jgates John Gates
                Watchers:
                Fritz Mueller, John Gates
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: