psfex tries to build with the wrong cc

XMLWordPrintable

Details

• Type: Bug
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:

Description

The eupspkg.cfg.sh file (in $LSSTSW/build/psfex/ups) allows a rebuild to incorrectly use whatever flavor of cc is found. The call to scons in build() should probably include cc="$CC", just like default_build() in \$EUPS_DIR/lib/eupspkg.sh does.

This was discussed in the hipchat DM Newbies room on 2016-09-22. In my case, on macOS Sierra, psfex was attempting to build with homebrew's gcc instead of clang. This caused the build to fail.

Activity

Hide
Tim Jenness added a comment -

I can understand why the config section of that file is special, but I don't understand why the build and install sections exist given that eupspkg preferentially choose scons. Is it overridden because -j doesn't work?

Show
Tim Jenness added a comment - I can understand why the config section of that file is special, but I don't understand why the build and install sections exist given that eupspkg preferentially choose scons. Is it overridden because -j doesn't work?
Hide
John Swinbank added a comment -

Let's take 'em out and see what happens...

Show
John Swinbank added a comment - Let's take 'em out and see what happens...
Hide
John Swinbank added a comment -

Took 'em out. Jenkins is happy, as is my laptop. Tim Jenness, do we need to do any other sanity checking before merging?

Show
John Swinbank added a comment - Took 'em out. Jenkins is happy, as is my laptop. Tim Jenness , do we need to do any other sanity checking before merging? Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/31255/pipeline/
Hide
Tim Jenness added a comment -

Looks good to me.

Show
Tim Jenness added a comment - Looks good to me.
Hide
Tim Jenness added a comment -

John Swinbank do I assume this built fine on a mac? (since Jenkins isn't testing that).

Show
Tim Jenness added a comment - John Swinbank do I assume this built fine on a mac? (since Jenkins isn't testing that).
Hide
Tim Jenness added a comment -

psfex builds fine on my mac.

Show
Tim Jenness added a comment - psfex builds fine on my mac.
Hide
John Swinbank added a comment -

Thanks for following up on this Tim — it totally fell off my radar.

Since we now have Mac Jenkins again, I'll do one more run, then go ahead and merge:

https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/31338/pipeline

Show
John Swinbank added a comment - Thanks for following up on this Tim — it totally fell off my radar. Since we now have Mac Jenkins again, I'll do one more run, then go ahead and merge: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/31338/pipeline

People

Assignee:
John Swinbank
Reporter:
Meredith Rawls
Reviewers:
Tim Jenness
Watchers:
John Swinbank, Meredith Rawls, Nate Lust, Tim Jenness