Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: psfex
-
Labels:
Description
The eupspkg.cfg.sh file (in $LSSTSW/build/psfex/ups) allows a rebuild to incorrectly use whatever flavor of cc is found. The call to scons in build() should probably include cc="$CC", just like default_build() in $EUPS_DIR/lib/eupspkg.sh does.
This was discussed in the hipchat DM Newbies room on 2016-09-22. In my case, on macOS Sierra, psfex was attempting to build with homebrew's gcc instead of clang. This caused the build to fail.
Attachments
Issue Links
- mentioned in
-
Page Loading...
Activity
| Field | Original Value | New Value |
|---|---|---|
| Description |
The eupspkg.cfg.sh file (in $LSSTSW/build/psfex/ups) allows a rebuild to incorrectly use whatever flavor of cc is found. The call to scons in build() should probably include cc="$CC", just like default_build() in $EUPS_DIR/lib/eupspkg.sh does.
This was discussed in the hipchat DM Newbies room on 2016-09-22. In my case, on macOS Sierra, psfex was attempting to build with homebrew's gcc instead of clang. This caused the build to fail. |
The {{eupspkg.cfg.sh}} file (in {{$LSSTSW/build/psfex/ups}}) allows a rebuild to incorrectly use whatever flavor of {{cc}} is found. The call to scons in build() should probably include {{cc="$CC"}}, just like {{default_build()}} in {{$EUPS_DIR/lib/eupspkg.sh}} does.
This was discussed in the hipchat DM Newbies room on 2016-09-22. In my case, on macOS Sierra, psfex was attempting to build with homebrew's gcc instead of clang. This caused the build to fail. |
| Description |
The {{eupspkg.cfg.sh}} file (in {{$LSSTSW/build/psfex/ups}}) allows a rebuild to incorrectly use whatever flavor of {{cc}} is found. The call to scons in build() should probably include {{cc="$CC"}}, just like {{default_build()}} in {{$EUPS_DIR/lib/eupspkg.sh}} does.
This was discussed in the hipchat DM Newbies room on 2016-09-22. In my case, on macOS Sierra, psfex was attempting to build with homebrew's gcc instead of clang. This caused the build to fail. |
The {{eupspkg.cfg.sh}} file (in {{$LSSTSW/build/psfex/ups}}) allows a rebuild to incorrectly use whatever flavor of {{cc}} is found. The call to scons in {{build()}} should probably include {{cc="$CC"}}, just like {{default_build()}} in {{$EUPS_DIR/lib/eupspkg.sh}} does.
This was discussed in the hipchat DM Newbies room on 2016-09-22. In my case, on macOS Sierra, psfex was attempting to build with homebrew's {{gcc}} instead of {{clang}}. This caused the build to fail. |
| Watchers | Meredith Rawls [ Meredith Rawls ] | Meredith Rawls, Nate Lust [ Meredith Rawls, Nate Lust ] |
| Assignee | John Swinbank [ swinbank ] |
| Remote Link | This issue links to "Page (Confluence)" [ 23281 ] |
Let's take 'em out and see what happens...
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
Took 'em out. Jenkins is happy, as is my laptop. Tim Jenness, do we need to do any other sanity checking before merging?
| Reviewers | Tim Jenness [ tjenness ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
Looks good to me.
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
| Assignee | John Swinbank [ swinbank ] |
John Swinbank do I assume this built fine on a mac? (since Jenkins isn't testing that).
psfex builds fine on my mac.
Thanks for following up on this Tim — it totally fell off my radar.
Since we now have Mac Jenkins again, I'll do one more run, then go ahead and merge:
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
I can understand why the config section of that file is special, but I don't understand why the build and install sections exist given that eupspkg preferentially choose scons. Is it overridden because -j doesn't work?