Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7718

psfex tries to build with the wrong cc

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: psfex

      Description

      The eupspkg.cfg.sh file (in $LSSTSW/build/psfex/ups) allows a rebuild to incorrectly use whatever flavor of cc is found. The call to scons in build() should probably include cc="$CC", just like default_build() in $EUPS_DIR/lib/eupspkg.sh does.

      This was discussed in the hipchat DM Newbies room on 2016-09-22. In my case, on macOS Sierra, psfex was attempting to build with homebrew's gcc instead of clang. This caused the build to fail.

        Attachments

          Issue Links

            Activity

            mrawls Meredith Rawls created issue -
            tjenness Tim Jenness made changes -
            Field Original Value New Value
            Description The eupspkg.cfg.sh file (in $LSSTSW/build/psfex/ups) allows a rebuild to incorrectly use whatever flavor of cc is found. The call to scons in build() should probably include cc="$CC", just like default_build() in $EUPS_DIR/lib/eupspkg.sh does.

            This was discussed in the hipchat DM Newbies room on 2016-09-22. In my case, on macOS Sierra, psfex was attempting to build with homebrew's gcc instead of clang. This caused the build to fail.
            The {{eupspkg.cfg.sh}} file (in {{$LSSTSW/build/psfex/ups}}) allows a rebuild to incorrectly use whatever flavor of {{cc}} is found. The call to scons in build() should probably include {{cc="$CC"}}, just like {{default_build()}} in {{$EUPS_DIR/lib/eupspkg.sh}} does.

            This was discussed in the hipchat DM Newbies room on 2016-09-22. In my case, on macOS Sierra, psfex was attempting to build with homebrew's gcc instead of clang. This caused the build to fail.
            tjenness Tim Jenness made changes -
            Description The {{eupspkg.cfg.sh}} file (in {{$LSSTSW/build/psfex/ups}}) allows a rebuild to incorrectly use whatever flavor of {{cc}} is found. The call to scons in build() should probably include {{cc="$CC"}}, just like {{default_build()}} in {{$EUPS_DIR/lib/eupspkg.sh}} does.

            This was discussed in the hipchat DM Newbies room on 2016-09-22. In my case, on macOS Sierra, psfex was attempting to build with homebrew's gcc instead of clang. This caused the build to fail.
            The {{eupspkg.cfg.sh}} file (in {{$LSSTSW/build/psfex/ups}}) allows a rebuild to incorrectly use whatever flavor of {{cc}} is found. The call to scons in {{build()}} should probably include {{cc="$CC"}}, just like {{default_build()}} in {{$EUPS_DIR/lib/eupspkg.sh}} does.

            This was discussed in the hipchat DM Newbies room on 2016-09-22. In my case, on macOS Sierra, psfex was attempting to build with homebrew's {{gcc}} instead of {{clang}}. This caused the build to fail.
            tjenness Tim Jenness made changes -
            Watchers Meredith Rawls [ Meredith Rawls ] Meredith Rawls, Nate Lust [ Meredith Rawls, Nate Lust ]
            Hide
            tjenness Tim Jenness added a comment -

            I can understand why the config section of that file is special, but I don't understand why the build and install sections exist given that eupspkg preferentially choose scons. Is it overridden because -j doesn't work?

            Show
            tjenness Tim Jenness added a comment - I can understand why the config section of that file is special, but I don't understand why the build and install sections exist given that eupspkg preferentially choose scons. Is it overridden because -j doesn't work?
            swinbank John Swinbank made changes -
            Assignee John Swinbank [ swinbank ]
            gcomoretto Gabriele Comoretto made changes -
            Remote Link This issue links to "Page (Confluence)" [ 23281 ]
            Hide
            swinbank John Swinbank added a comment -

            Let's take 'em out and see what happens...

            Show
            swinbank John Swinbank added a comment - Let's take 'em out and see what happens...
            swinbank John Swinbank made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            swinbank John Swinbank added a comment -

            Took 'em out. Jenkins is happy, as is my laptop. Tim Jenness, do we need to do any other sanity checking before merging?

            Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/31255/pipeline/

            Show
            swinbank John Swinbank added a comment - Took 'em out. Jenkins is happy, as is my laptop. Tim Jenness , do we need to do any other sanity checking before merging? Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/31255/pipeline/
            swinbank John Swinbank made changes -
            Reviewers Tim Jenness [ tjenness ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            tjenness Tim Jenness added a comment -

            Looks good to me.

            Show
            tjenness Tim Jenness added a comment - Looks good to me.
            tjenness Tim Jenness made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            tjenness Tim Jenness made changes -
            Assignee John Swinbank [ swinbank ]
            Hide
            tjenness Tim Jenness added a comment -

            John Swinbank do I assume this built fine on a mac? (since Jenkins isn't testing that).

            Show
            tjenness Tim Jenness added a comment - John Swinbank do I assume this built fine on a mac? (since Jenkins isn't testing that).
            Hide
            tjenness Tim Jenness added a comment -

            psfex builds fine on my mac.

            Show
            tjenness Tim Jenness added a comment - psfex builds fine on my mac.
            Hide
            swinbank John Swinbank added a comment -

            Thanks for following up on this Tim — it totally fell off my radar.

            Since we now have Mac Jenkins again, I'll do one more run, then go ahead and merge:

            https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/31338/pipeline

            Show
            swinbank John Swinbank added a comment - Thanks for following up on this Tim — it totally fell off my radar. Since we now have Mac Jenkins again, I'll do one more run, then go ahead and merge: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/31338/pipeline
            swinbank John Swinbank made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              swinbank John Swinbank
              Reporter:
              mrawls Meredith Rawls
              Reviewers:
              Tim Jenness
              Watchers:
              John Swinbank, Meredith Rawls, Nate Lust, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: