Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7756

Port pipe_drivers to Python 3

    XMLWordPrintable

Details

    • 0.5
    • Alert Production S17 - 2
    • Alert Production

    Description

      pipe_drivers needs to be converted to python 3.

      Attachments

        Issue Links

          Activity

            tjenness Tim Jenness added a comment - - edited

            I've had a quick look at pipe_drivers and it looks like the port to python 3 will be pretty easy: a couple of old-style exceptions, some use of itervalues(), other minor tweaks.

            Currently lsst_distrib works fine regardless because there are no tests in pipe_drivers to fail (DM-9059).

            tjenness Tim Jenness added a comment - - edited I've had a quick look at pipe_drivers and it looks like the port to python 3 will be pretty easy: a couple of old-style exceptions, some use of itervalues() , other minor tweaks. Currently lsst_distrib works fine regardless because there are no tests in pipe_drivers to fail ( DM-9059 ).
            rowen Russell Owen added a comment - - edited

            I want to do this before the fixes for pybind11 DM-8462

            rowen Russell Owen added a comment - - edited I want to do this before the fixes for pybind11 DM-8462
            rowen Russell Owen added a comment -

            A standard port. Pretty easy. One minor point: I ran autopep8 without the default line length because we are switching to 80 character lines. However, I was not religious about fixing any remaining lines that were longer. Call it a start in that direction.

            rowen Russell Owen added a comment - A standard port. Pretty easy. One minor point: I ran autopep8 without the default line length because we are switching to 80 character lines. However, I was not religious about fixing any remaining lines that were longer. Call it a start in that direction.
            tjenness Tim Jenness added a comment -

            Can you make a pull request? There are some extra list() calls that you don't need.

            tjenness Tim Jenness added a comment - Can you make a pull request? There are some extra list() calls that you don't need.
            rowen Russell Owen added a comment -

            I removed all unnecessary list(...) and .keys(). I also found two more instances of foo = lambda that I turned into normal functions and added one # noqa to hide a linter warning caused by standard_library.install_aliases() being needed before some module-level import statements.

            rowen Russell Owen added a comment - I removed all unnecessary list(...) and .keys() . I also found two more instances of foo = lambda that I turned into normal functions and added one # noqa to hide a linter warning caused by standard_library.install_aliases() being needed before some module-level import statements.
            tjenness Tim Jenness added a comment -

            The lack of tests is a worry but these cleanups look fine to me. I'm happy to call this reviewed if price is too busy.

            tjenness Tim Jenness added a comment - The lack of tests is a worry but these cleanups look fine to me. I'm happy to call this reviewed if price is too busy.
            rowen Russell Owen added a comment -

            Marking "reviewed" as per tjenness's comments above. Note that I also ran constructBias.py successfully under python 2, so at least that did not get broken by these changes.

            rowen Russell Owen added a comment - Marking "reviewed" as per tjenness 's comments above. Note that I also ran constructBias.py successfully under python 2, so at least that did not get broken by these changes.
            rowen Russell Owen added a comment -

            Rebased to clean up the commit history a bit and merged.

            rowen Russell Owen added a comment - Rebased to clean up the commit history a bit and merged.

            People

              rowen Russell Owen
              tjenness Tim Jenness
              Tim Jenness
              John Swinbank, Paul Price, Russell Owen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.