Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7756

Port pipe_drivers to Python 3

    Details

    • Story Points:
      0.5
    • Sprint:
      Alert Production S17 - 2
    • Team:
      Alert Production

      Description

      pipe_drivers needs to be converted to python 3.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment - - edited

            I've had a quick look at pipe_drivers and it looks like the port to python 3 will be pretty easy: a couple of old-style exceptions, some use of itervalues(), other minor tweaks.

            Currently lsst_distrib works fine regardless because there are no tests in pipe_drivers to fail (DM-9059).

            Show
            tjenness Tim Jenness added a comment - - edited I've had a quick look at pipe_drivers and it looks like the port to python 3 will be pretty easy: a couple of old-style exceptions, some use of itervalues() , other minor tweaks. Currently lsst_distrib works fine regardless because there are no tests in pipe_drivers to fail ( DM-9059 ).
            Hide
            rowen Russell Owen added a comment - - edited

            I want to do this before the fixes for pybind11 DM-8462

            Show
            rowen Russell Owen added a comment - - edited I want to do this before the fixes for pybind11 DM-8462
            Hide
            rowen Russell Owen added a comment -

            A standard port. Pretty easy. One minor point: I ran autopep8 without the default line length because we are switching to 80 character lines. However, I was not religious about fixing any remaining lines that were longer. Call it a start in that direction.

            Show
            rowen Russell Owen added a comment - A standard port. Pretty easy. One minor point: I ran autopep8 without the default line length because we are switching to 80 character lines. However, I was not religious about fixing any remaining lines that were longer. Call it a start in that direction.
            Hide
            tjenness Tim Jenness added a comment -

            Can you make a pull request? There are some extra list() calls that you don't need.

            Show
            tjenness Tim Jenness added a comment - Can you make a pull request? There are some extra list() calls that you don't need.
            Hide
            rowen Russell Owen added a comment -

            I removed all unnecessary list(...) and .keys(). I also found two more instances of foo = lambda that I turned into normal functions and added one # noqa to hide a linter warning caused by standard_library.install_aliases() being needed before some module-level import statements.

            Show
            rowen Russell Owen added a comment - I removed all unnecessary list(...) and .keys() . I also found two more instances of foo = lambda that I turned into normal functions and added one # noqa to hide a linter warning caused by standard_library.install_aliases() being needed before some module-level import statements.
            Hide
            tjenness Tim Jenness added a comment -

            The lack of tests is a worry but these cleanups look fine to me. I'm happy to call this reviewed if Paul Price is too busy.

            Show
            tjenness Tim Jenness added a comment - The lack of tests is a worry but these cleanups look fine to me. I'm happy to call this reviewed if Paul Price is too busy.
            Hide
            rowen Russell Owen added a comment -

            Marking "reviewed" as per Tim Jenness's comments above. Note that I also ran constructBias.py successfully under python 2, so at least that did not get broken by these changes.

            Show
            rowen Russell Owen added a comment - Marking "reviewed" as per Tim Jenness 's comments above. Note that I also ran constructBias.py successfully under python 2, so at least that did not get broken by these changes.
            Hide
            rowen Russell Owen added a comment -

            Rebased to clean up the commit history a bit and merged.

            Show
            rowen Russell Owen added a comment - Rebased to clean up the commit history a bit and merged.

              People

              • Assignee:
                rowen Russell Owen
                Reporter:
                tjenness Tim Jenness
                Reviewers:
                Tim Jenness
                Watchers:
                John Swinbank, Paul Price, Russell Owen, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel