Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7769

duplicate imports in CharacterizeImageTask

    XMLWordPrintable

Details

    • Bug
    • Status: Done
    • Resolution: Done
    • None
    • pipe_tasks
    • None
    • 1
    • Alert Production F16 - 9, Alert Production F16 - 10, Alert Production F16 - 11, Alert Production F16 - 11b, Alert Production F16 - 11c
    • Alert Production

    Description

      A few duplicate imports snuck into CharacterizeImageTask in a recent change.

      It's a one-liner to fix. However, pep8 also picked up the fact that lines 565-569 are indented too far. Might as well fix that as well and run flake8 on all python code.

      Attachments

        Activity

          rowen Russell Owen added a comment -

          fred3m I'm hoping you can fix this as part of your Python 3 update to pipe_tasks (I see you listed as working on that now). If not, feel free to assign it back to me.

          rowen Russell Owen added a comment - fred3m I'm hoping you can fix this as part of your Python 3 update to pipe_tasks (I see you listed as working on that now). If not, feel free to assign it back to me.

          rowen, I'm involved in a few other projects so I think that mrawls is working on the pipe_tasks python 3 port now. I think I forgot to update the confluence page.

          fred3m Fred Moolekamp added a comment - rowen , I'm involved in a few other projects so I think that mrawls is working on the pipe_tasks python 3 port now. I think I forgot to update the confluence page.

          Got it. If we're being picky, which I gather we are, the multi-line keyword assignment in characterizeImage.py is not currently following our whitespace conventions from the style guide. I'm also not entirely sold on the idea that multi-line keyword assignments need to be quite as prolific as they are here. Input welcome.

          mrawls Meredith Rawls added a comment - Got it. If we're being picky, which I gather we are, the multi-line keyword assignment in characterizeImage.py is not currently following our whitespace conventions from the style guide . I'm also not entirely sold on the idea that multi-line keyword assignments need to be quite as prolific as they are here. Input welcome.
          rowen Russell Owen added a comment -

          Can you please be more specific about what isn't following our style guide? I thought the code was clean.

          rowen Russell Owen added a comment - Can you please be more specific about what isn't following our style guide? I thought the code was clean.

          Specifically, the statement/section "Keyword assignment operators SHOULD be surrounded by a space when statements appear on multiple lines." The style guide suggests only omitting these spaces when the keyword assignments are listed on a single line.

          mrawls Meredith Rawls added a comment - Specifically, the statement/section "Keyword assignment operators SHOULD be surrounded by a space when statements appear on multiple lines." The style guide suggests only omitting these spaces when the keyword assignments are listed on a single line.
          rowen Russell Owen added a comment -

          Yes that is worth fixing if you're willing to do it. (You probably already know this, but please don't add spaces when a default value is being specified; for some reason we forbid that in Python and C++).

          rowen Russell Owen added a comment - Yes that is worth fixing if you're willing to do it. (You probably already know this, but please don't add spaces when a default value is being specified; for some reason we forbid that in Python and C++).

          This was done in parallel with DM-7292.

          mrawls Meredith Rawls added a comment - This was done in parallel with DM-7292 .

          Completed as part of DM-7292.

          mrawls Meredith Rawls added a comment - Completed as part of DM-7292 .

          People

            mrawls Meredith Rawls
            rowen Russell Owen
            Nate Lust
            Fred Moolekamp, Meredith Rawls, Nate Lust, Russell Owen
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Jenkins

                No builds found.