Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: pipe_tasks
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Alert Production F16 - 9, Alert Production F16 - 10, Alert Production F16 - 11, Alert Production F16 - 11b, Alert Production F16 - 11c
-
Team:Alert Production
Description
A few duplicate imports snuck into CharacterizeImageTask in a recent change.
It's a one-liner to fix. However, pep8 also picked up the fact that lines 565-569 are indented too far. Might as well fix that as well and run flake8 on all python code.
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Watchers | Russell Owen [ Russell Owen ] | Nate Lust, Russell Owen [ Nate Lust, Russell Owen ] |
| Assignee | Russell Owen [ rowen ] | Fred Moolekamp [ fred3m ] |
Russell Owen, I'm involved in a few other projects so I think that Meredith Rawls is working on the pipe_tasks python 3 port now. I think I forgot to update the confluence page.
Fred Moolekamp
added a comment - Russell Owen , I'm involved in a few other projects so I think that Meredith Rawls is working on the pipe_tasks python 3 port now. I think I forgot to update the confluence page. | Assignee | Fred Moolekamp [ fred3m ] | Meredith Rawls [ mrawls ] |
| Sprint | Alert Production F16 - 9 [ 247 ] | |
| Team | Alert Production [ 10300 ] |
Got it. If we're being picky, which I gather we are, the multi-line keyword assignment in characterizeImage.py is not currently following our whitespace conventions from the style guide. I'm also not entirely sold on the idea that multi-line keyword assignments need to be quite as prolific as they are here. Input welcome.
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
Can you please be more specific about what isn't following our style guide? I thought the code was clean.
Specifically, the statement/section "Keyword assignment operators SHOULD be surrounded by a space when statements appear on multiple lines." The style guide suggests only omitting these spaces when the keyword assignments are listed on a single line.
Yes that is worth fixing if you're willing to do it. (You probably already know this, but please don't add spaces when a default value is being specified; for some reason we forbid that in Python and C++).
| Story Points | 1 |
| Sprint | Alert Production F16 - 9 [ 247 ] | Alert Production F16 - 9, Alert Production F16 - 10 [ 247, 284 ] |
| Rank | Ranked higher |
| Epic Link |
|
| Epic Link |
|
| Epic Link |
|
This was done in parallel with DM-7292.
| Reviewers | Nate Lust [ nlust ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
| Sprint | Alert Production F16 - 9, Alert Production F16 - 10 [ 247, 284 ] | Alert Production F16 - 9, Alert Production F16 - 10, Alert Production F16 - 11 [ 247, 284, 289 ] |
| Sprint | Alert Production F16 - 9, Alert Production F16 - 10, Alert Production F16 - 11 [ 247, 284, 289 ] | Alert Production F16 - 9, Alert Production F16 - 10, Alert Production F16 - 11, Alert Production F16 - 11b [ 247, 284, 289, 295 ] |
| Rank | Ranked higher |
| Sprint | Alert Production F16 - 9, Alert Production F16 - 10, Alert Production F16 - 11, Alert Production F16 - 11b [ 247, 284, 289, 295 ] | Alert Production F16 - 9, Alert Production F16 - 10, Alert Production F16 - 11, Alert Production F16 - 11b, Alert Production F16 - 11c [ 247, 284, 289, 295, 296 ] |
Completed as part of DM-7292.
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
Fred Moolekamp I'm hoping you can fix this as part of your Python 3 update to pipe_tasks (I see you listed as working on that now). If not, feel free to assign it back to me.