Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7797

Wrap afw::image with pybind11

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Story Points:
      12.9
    • Epic Link:
    • Sprint:
      DRP F16-5, DRP F16-6, DRP S17-1
    • Team:
      Data Release Production

      Description

      The generated wrappers will live parallel to the Swig wrappers. This ticket only covers the C++ wrappers themselves, not the Python layer on top (which will continue to use the old wrappers) all work will stay on a separate branch and will not be merged to master until DM-6168 is complete.

      The tests included in this ticket are:

      1. testFluxFromABMag.py
      2. testWcs835.py
      3. testHeader.py
      4. testTableArchiveImport.py
      5. testMaskedImagePersistence1.py
      6. testImageIo2.py
      7. testTicket2352.py
      8. testTicket2905.py
      9. testImagePersistence1.py
      10. testScaledPlus.py
      11. testRandom1.py
      12. testImageTestUtils.py
      13. testKernel.py
      14. testWcsFitsTable.py
      15. testTicket2162.py
      16. testStatisticsOverloads.py
      17. testMakeWcs.py
      18. testStatisticsMasked.py
      19. testKernelIo1.py
      20. testEllipse.py
      21. testRowColumnStats.py
      22. testMethods.py
      23. testKernelImagesForRegion.py
      24. statBug1697.py

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7057 Complete afw port to pybind11

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-7801 Wrap afw::cameraGeom with pybind11

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8417 Wrap tests that depend on both image and table with pybind11

          • Done
          is blocked by

          Improvement - An improvement or enhancement to an existing feature or task. DM-8363 Add macro for Pybind11 wrapping of LSST_CONTROL_FIELD

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-8374 Add function for Pybind11 wrapping of PersistableFacade

          • Done
          is cloned by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-8447 Wrap afw::image with pybind11 (UW work)

          • Done

            Activity

            Ascending order - Click to sort in descending order
            5 older comments
            Hide
            Permalink
            pschella Pim Schellart [X] (Inactive) added a comment -

            Moved the following tests to DM-8417.

            • testValidPolygon
            • testTableUtils
            • testApCorrMap
            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Moved the following tests to DM-8417 . testValidPolygon testTableUtils testApCorrMap
            Hide
            Permalink
            pschella Pim Schellart [X] (Inactive) added a comment -

            Note that all commits will be squashed into one wrap lsst::image commit before merge to epic branch. But kept separate for review.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Note that all commits will be squashed into one wrap lsst::image commit before merge to epic branch. But kept separate for review.
            Hide
            Permalink
            krzys Krzysztof Findeisen added a comment -

            Split off my work as DM-8447.

            Show
            krzys Krzysztof Findeisen added a comment - Split off my work as DM-8447 .
            Hide
            Permalink
            fred3m Fred Moolekamp added a comment -

            Everything looks good. I had a few minor comments and some questions about a slight change in the API in a few tests. I did't see any notes about Jenkins, so make sure that it passes py 2 and 3 after rebasing with DM-6168.

            Show
            fred3m Fred Moolekamp added a comment - Everything looks good. I had a few minor comments and some questions about a slight change in the API in a few tests. I did't see any notes about Jenkins, so make sure that it passes py 2 and 3 after rebasing with DM-6168 .
            Hide
            Permalink
            pschella Pim Schellart [X] (Inactive) added a comment -

            Merged.

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Merged.

              People

              Assignee:
              pschella Pim Schellart [X] (Inactive)
              Reporter:
              fred3m Fred Moolekamp
              Reviewers:
              Fred Moolekamp
              Watchers:
              Fred Moolekamp, Krzysztof Findeisen, Pim Schellart [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.