Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7797

Wrap afw::image with pybind11

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • afw
    • 12.9
    • DRP F16-5, DRP F16-6, DRP S17-1
    • Data Release Production

    Description

      The generated wrappers will live parallel to the Swig wrappers. This ticket only covers the C++ wrappers themselves, not the Python layer on top (which will continue to use the old wrappers) all work will stay on a separate branch and will not be merged to master until DM-6168 is complete.

      The tests included in this ticket are:

      1. testFluxFromABMag.py
      2. testWcs835.py
      3. testHeader.py
      4. testTableArchiveImport.py
      5. testMaskedImagePersistence1.py
      6. testImageIo2.py
      7. testTicket2352.py
      8. testTicket2905.py
      9. testImagePersistence1.py
      10. testScaledPlus.py
      11. testRandom1.py
      12. testImageTestUtils.py
      13. testKernel.py
      14. testWcsFitsTable.py
      15. testTicket2162.py
      16. testStatisticsOverloads.py
      17. testMakeWcs.py
      18. testStatisticsMasked.py
      19. testKernelIo1.py
      20. testEllipse.py
      21. testRowColumnStats.py
      22. testMethods.py
      23. testKernelImagesForRegion.py
      24. statBug1697.py

      Attachments

        Issue Links

          Activity

            testChebyshevBoundedField requires lsst.afw.image but it was originally placed in DM-6298 since lsst.afw.image was not explicitly imported (even though afw.image is required to be wrapped for the test). The Description has been modified to reflect the change.

            fred3m Fred Moolekamp added a comment - testChebyshevBoundedField requires lsst.afw.image but it was originally placed in DM-6298 since lsst.afw.image was not explicitly imported (even though afw.image is required to be wrapped for the test). The Description has been modified to reflect the change.

            testSpatialCell.py was wrapped in DM-6298 with afw.math but the last test requires afw.image. The test is currently skipped but this test should be executed to verify that it passes before this ticket is completed.

            fred3m Fred Moolekamp added a comment - testSpatialCell.py was wrapped in DM-6298 with afw.math but the last test requires afw.image. The test is currently skipped but this test should be executed to verify that it passes before this ticket is completed.

            Moved pickling tests to DM-8415.
            This removes:

            • testPickles.py
            • imagePickle.py
            • testTicket2233.py

            from this ticket.

            pschella Pim Schellart [X] (Inactive) added a comment - Moved pickling tests to DM-8415 . This removes: testPickles.py imagePickle.py testTicket2233.py from this ticket.

            Moved testDs9.py to DM-7799.

            pschella Pim Schellart [X] (Inactive) added a comment - - edited Moved testDs9.py to DM-7799 .

            Moved testWarper.py to DM-7801.

            pschella Pim Schellart [X] (Inactive) added a comment - Moved testWarper.py to DM-7801 .

            Moved the following tests to DM-8417.

            • testValidPolygon
            • testTableUtils
            • testApCorrMap
            pschella Pim Schellart [X] (Inactive) added a comment - Moved the following tests to DM-8417 . testValidPolygon testTableUtils testApCorrMap

            Note that all commits will be squashed into one wrap lsst::image commit before merge to epic branch. But kept separate for review.

            pschella Pim Schellart [X] (Inactive) added a comment - Note that all commits will be squashed into one wrap lsst::image commit before merge to epic branch. But kept separate for review.

            Split off my work as DM-8447.

            krzys Krzysztof Findeisen added a comment - Split off my work as DM-8447 .

            Everything looks good. I had a few minor comments and some questions about a slight change in the API in a few tests. I did't see any notes about Jenkins, so make sure that it passes py 2 and 3 after rebasing with DM-6168.

            fred3m Fred Moolekamp added a comment - Everything looks good. I had a few minor comments and some questions about a slight change in the API in a few tests. I did't see any notes about Jenkins, so make sure that it passes py 2 and 3 after rebasing with DM-6168 .

            People

              pschella Pim Schellart [X] (Inactive)
              fred3m Fred Moolekamp
              Fred Moolekamp
              Fred Moolekamp, Krzysztof Findeisen, Pim Schellart [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.