Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7897

Migrate pybind11 port to use new base specifier

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Story Points:
      1
    • Sprint:
      DRP F16-5
    • Team:
      Data Release Production

      Description

      The new upstream pybind11 now has support for multiple inheritance.
      In implementing this, the way bases are specified has changed. The py::base template has been deprecated in favour of listing the bases directly.
      This ticket aims to modify our code accordingly.

        Attachments

          Activity

          Hide
          pschella Pim Schellart [X] (Inactive) added a comment -

          Done.
          And switching to the new base specifier even caught a bug (a wrong base was used for StringDestination)

          Show
          pschella Pim Schellart [X] (Inactive) added a comment - Done. And switching to the new base specifier even caught a bug (a wrong base was used for StringDestination )
          Hide
          fred3m Fred Moolekamp added a comment -

          In pex_policy there was one class that didn't inherit from the same base class it was using before (although you may have realized that it didn't need to inherit the base anymore). Otherwise this is good to go.

          Show
          fred3m Fred Moolekamp added a comment - In pex_policy there was one class that didn't inherit from the same base class it was using before (although you may have realized that it didn't need to inherit the base anymore). Otherwise this is good to go.
          Hide
          pschella Pim Schellart [X] (Inactive) added a comment -

          Yes, that was the bug I fixed

          Show
          pschella Pim Schellart [X] (Inactive) added a comment - Yes, that was the bug I fixed

            People

            Assignee:
            pschella Pim Schellart [X] (Inactive)
            Reporter:
            pschella Pim Schellart [X] (Inactive)
            Reviewers:
            Fred Moolekamp
            Watchers:
            Fred Moolekamp, Pim Schellart [X] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.