Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7934

Set FitSipDistortionTask as default and remove FitTanSipWcsTask (etc)

    XMLWordPrintable

Details

    • 3

    Description

      Once the new FitSipDistortionTask introduced on DM-3549 has been fully vetted, it should be set as the default. The task it replaces (FitTanSipWcsTask) and the C++ code it uses (namespace meas::astrom::sip) should then be removed.

      Attachments

        Issue Links

          Activity

            jbosch Jim Bosch added a comment -

            Code comments about this plan should also be removed from fitSipDistortion.py.

            jbosch Jim Bosch added a comment - Code comments about this plan should also be removed from fitSipDistortion.py.
            jbosch Jim Bosch added a comment -

            Removing the old SIP fitter will also require using the new one in the astrometry.net tasks (or removing them), so this is a bit trickier than I originally guessed.

            jbosch Jim Bosch added a comment - Removing the old SIP fitter will also require using the new one in the astrometry.net tasks (or removing them), so this is a bit trickier than I originally guessed.

            jbosch — thoughts about the current usefulness of this ticket?

            In particular, I note:

            • The astrometry.net tasks have been removed, so presumably no effort is required there.
            • I'm not clear if this is useful, or if we should just continue moving (slowly) towards using the new fitter on DM-20371.
            • Not setting this as default means that it has (presumably) never received the sort of battle-testing that would qualify it as “fully vetted”.
            swinbank John Swinbank added a comment - jbosch — thoughts about the current usefulness of this ticket? In particular, I note: The astrometry.net tasks have been removed, so presumably no effort is required there. I'm not clear if this is useful, or if we should just continue moving (slowly) towards using the new fitter on DM-20371 . Not setting this as default means that it has (presumably) never received the sort of battle-testing that would qualify it as “fully vetted”.
            jbosch Jim Bosch added a comment -

            We can probably drop this fitter and associated tickets in favor of the DM-20371 one.

            jbosch Jim Bosch added a comment - We can probably drop this fitter and associated tickets in favor of the DM-20371 one.

            Thanks Jim.

            swinbank John Swinbank added a comment - Thanks Jim.

            People

              Unassigned Unassigned
              jbosch Jim Bosch
              Jim Bosch, John Swinbank
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.