[DM-7940] Disable colourisation when not writing to a terminal - Jira

Robert Lupton created issue - 10/Oct/16 9:27 AM

Hide

Permalink

Robert Lupton added a comment - 10/Oct/16 9:31 AM

Trivial change, needed to make ~~DM-5421~~ more user friendly

Show

Robert Lupton added a comment - 10/Oct/16 9:31 AM Trivial change, needed to make DM-5421 more user friendly

Robert Lupton made changes - 10/Oct/16 9:31 AM

Field	Original Value	New Value
Reviewers		Russell Owen [ rowen ]
Status	To Do [ 10001 ]	In Review [ 10004 ]

Hide

Permalink

Russell Owen added a comment - 10/Oct/16 10:40 AM - edited

Please document the change in the doc string for the Color.colorize method. Other than that it looks fine.

As an aside: I am surprised that Color._colorize is a class variable instead of an instance variable, and similarly that Color.colorize is static. I wish the class had a doc string, but it's out of scope to ask you to add one.

Show

Russell Owen added a comment - 10/Oct/16 10:40 AM - edited Please document the change in the doc string for the Color.colorize method. Other than that it looks fine. As an aside: I am surprised that Color._colorize is a class variable instead of an instance variable, and similarly that Color.colorize is static. I wish the class had a doc string, but it's out of scope to ask you to add one.

Russell Owen made changes - 10/Oct/16 10:40 AM

Status

In Review [ 10004 ]

Reviewed [ 10101 ]

Hide

Permalink

Robert Lupton added a comment - 10/Oct/16 2:37 PM

Done; I also added a class doc string.

I think it makes sense for that to be a class variable – it's state about how you want to use colour. It would be nice to add 'with' support, but I think that's out of scope.

Show

Robert Lupton added a comment - 10/Oct/16 2:37 PM Done; I also added a class doc string. I think it makes sense for that to be a class variable – it's state about how you want to use colour. It would be nice to add 'with' support, but I think that's out of scope.

Robert Lupton made changes - 10/Oct/16 2:37 PM

Resolution		Done [ 10000 ]
Status	Reviewed [ 10101 ]	Done [ 10002 ]

Tim Jenness made changes - 12/Oct/16 9:33 AM

Labels

SciencePipelines

Tim Jenness made changes - 12/Oct/16 9:33 AM

Team

Data Release Production [ 10301 ]

John Swinbank made changes - 14/Oct/16 6:08 AM

Component/s

pex_config [ 10729 ]

John Swinbank made changes - 14/Oct/16 6:10 AM

Epic Link

~~DM-6172~~ [ 24685 ]

John Swinbank made changes - 14/Oct/16 6:10 AM

Sprint		DRP F16-5 [ 252 ]
Story Points		0.5

John Swinbank made changes - 14/Oct/16 6:11 AM

Remote Link