# Fix config for reference object loader

XMLWordPrintable

## Details

• Type: Bug
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
None
• Story Points:
1
• Sprint:
DRP F16-5, DRP F16-6
• Team:
Data Release Production

## Description

meas_mosaic if failing to un-persist the source matches for the HSC NB0921 filter with:

  WARNING: Failed to read DataId(initialdata={'taiObs': '2015-03-16', 'pointing': 1170, 'visit': 23046, 'dateObs': '2015-03-16', 'filter': 'NB0921', 'field': 'SSP_UDEEP_COSMOS', 'tract': 0, 'ccd': 41, 'expTime': 900.0}, tag=set([])): Could not find flux field(s) N921_camFlux, N921_flux 

It seems the filterMap is not being loaded properly. Please fix this.

## Activity

Hide
Lauren MacArthur added a comment -

John, would you mind giving this a look? I can confirm that the problem has indeed been fixed (having processed all the the NB0921 band RC dataset of DM-6816 through meas_mosaic). If you wanted to test it yourself, you could point to the following rerun on tiger:
lauren/LSST/DM-6816/cosmos and the NB0921 visits are:
cosmosVisitsNB0921=23038..23056:2^23594..23606:2^24298..24310:2^25810..25816:2.
A Jenkins build (of just meas_mosaic) is happy.

Show
Lauren MacArthur added a comment - John, would you mind giving this a look? I can confirm that the problem has indeed been fixed (having processed all the the NB0921 band RC dataset of DM-6816 through meas_mosaic ). If you wanted to test it yourself, you could point to the following rerun on tiger: lauren/LSST/ DM-6816 /cosmos and the NB0921 visits are: cosmosVisitsNB0921=23038..23056:2^23594..23606:2^24298..24310:2^25810..25816:2 . A Jenkins build (of just meas_mosaic ) is happy.
Hide
John Swinbank added a comment -

So this worries me:

 >>> LoadAstrometryNetObjectsTask.ConfigClass  >>> ANetBasicAstrometryConfig  

You appear to be replacing the former with the latter, but they aren't actually the same. In practice, I think it doesn't matter, since they both have a filterMap and I guess that's all you need, but we should probably fix it. Since I don't think we use config.astrom anywhere other than here, you can probably just change it into a LoadAstrometryNetObjectsTask.ConfigClass. And change the docstring, because it's not being used as a "configuration for readMatches".

Show
John Swinbank added a comment - So this worries me: >>> LoadAstrometryNetObjectsTask.ConfigClass <class 'lsst.meas.algorithms.loadReferenceObjects.LoadReferenceObjectsConfig'> >>> ANetBasicAstrometryConfig <class 'lsst.meas.astrom.anetBasicAstrometry.ANetBasicAstrometryConfig'> You appear to be replacing the former with the latter, but they aren't actually the same. In practice, I think it doesn't matter, since they both have a filterMap and I guess that's all you need, but we should probably fix it. Since I don't think we use config.astrom anywhere other than here, you can probably just change it into a LoadAstrometryNetObjectsTask.ConfigClass . And change the docstring, because it's not being used as a "configuration for readMatches".
Hide
Lauren MacArthur added a comment -

Excellent point! I've updated accordingly. I decided to change the name astrom to loadAstrom to be slightly more explicit about the fact that it's just the loader we are using. This required updates to the filterMap config overrides in obs_subaru. I've pushed the updates and tested them locally. A Jenkins build (this time on lsst_distrib ci_hsc meas_mosaic) is running.

Show
Lauren MacArthur added a comment - Excellent point! I've updated accordingly. I decided to change the name astrom to loadAstrom to be slightly more explicit about the fact that it's just the loader we are using. This required updates to the filterMap config overrides in obs_subaru . I've pushed the updates and tested them locally. A Jenkins build (this time on lsst_distrib ci_hsc meas_mosaic ) is running.
Hide
John Swinbank added a comment -

Thanks!

Show
John Swinbank added a comment - Thanks!
Hide
Lauren MacArthur added a comment -

Merged to master.

Show
Lauren MacArthur added a comment - Merged to master.

## People

• Assignee:
Lauren MacArthur
Reporter:
Lauren MacArthur
Reviewers:
John Swinbank
Watchers:
John Swinbank, Lauren MacArthur