Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7956

Add the Starlink AST package

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Epic Link:
    • Sprint:
      Alert Production F16 - 10
    • Team:
      Alert Production

      Description

      As per RFC-193 add the starlink AST package. Name it starlink_ast.

      Note: until we have the new WCS code further along it seems premature to add starlink_ast to lsst_distrib

        Attachments

          Issue Links

          is triggered by

          RFC - An issue whose primary purpose is to advertise an intent and allow stakeholders to comment. RFC-193 Adopt AST for WCS and transforms

          • Implemented
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. DM-7953 Describe how to distribute 3rd party forked packages

          • Invalid

            Activity

            Ascending order - Click to sort in descending order
            13 older comments
            Hide
            Permalink
            rowen Russell Owen added a comment -

            I think Tim Jenness is satisfied (please correct me if not!) so John Parejko please mark this as reviewed when you are also satisfied.

            Show
            rowen Russell Owen added a comment - I think Tim Jenness is satisfied (please correct me if not!) so John Parejko please mark this as reviewed when you are also satisfied.
            Hide
            Permalink
            Parejkoj John Parejko added a comment -

            Thanks, that's more managable.

            Show
            Parejkoj John Parejko added a comment - Thanks, that's more managable.
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Jenkins fails to build it. Here is a console log: https://ci.lsst.codes/job/stack-os-matrix/label=centos-7,python=py2/17142//consoleFull

            and here is an excerpt:

            [2016-10-12T00:29:01.067547Z] In file included from grf_pgplot.c:78:0:
            		 
            [2016-10-12T00:29:01.067650Z] grf_pgplot.c:131:91: error: unknown type name 'text_length'
            		 
            [2016-10-12T00:29:01.067702Z]  F77_SUBROUTINE(pgptxt)( REAL(x), REAL(y), REAL(angle), REAL(fjust), CHARACTER(text) TRAIL(text) );
            		 
            [2016-10-12T00:29:01.067754Z]                                                                                            ^
            		 
            [2016-10-12T00:29:01.067787Z] f77.h:407:36: note: in definition of macro 'TRAIL'
            		 
            [2016-10-12T00:29:01.067818Z]  #define TRAIL(X)                 , X ## _length
            		 
            [2016-10-12T00:29:01.067846Z]                                     ^

            The command rebuild starlink_ast works fine on my Mac, but that does not have fortran available. That file f77.h has also been troublesome because the installation step modifies it (at least on my Mac) rendering it unusable and leaving it listed as modified, meaning it would be all too easy to commit the broken version. However, that is not what happened in this case.

            Show
            rowen Russell Owen added a comment - Jenkins fails to build it. Here is a console log: https://ci.lsst.codes/job/stack-os-matrix/label=centos-7,python=py2/17142//consoleFull and here is an excerpt: [2016-10-12T00:29:01.067547Z] In file included from grf_pgplot.c:78:0: [2016-10-12T00:29:01.067650Z] grf_pgplot.c:131:91: error: unknown type name 'text_length' [2016-10-12T00:29:01.067702Z] F77_SUBROUTINE(pgptxt)( REAL(x), REAL(y), REAL(angle), REAL(fjust), CHARACTER(text) TRAIL(text) ); [2016-10-12T00:29:01.067754Z] ^ [2016-10-12T00:29:01.067787Z] f77.h:407:36: note: in definition of macro 'TRAIL' [2016-10-12T00:29:01.067818Z] #define TRAIL(X) , X ## _length [2016-10-12T00:29:01.067846Z] ^ The command rebuild starlink_ast works fine on my Mac, but that does not have fortran available. That file f77.h has also been troublesome because the installation step modifies it (at least on my Mac) rendering it unusable and leaving it listed as modified, meaning it would be all too easy to commit the broken version. However, that is not what happened in this case.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            I have a possible fix for this upstream: https://github.com/Starlink/ast/pull/2

            Show
            tjenness Tim Jenness added a comment - I have a possible fix for this upstream: https://github.com/Starlink/ast/pull/2
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Tim Jenness's fix worked very well. I was able to remove f77.h, which is a huge relief, and it all builds on Jenkins (py2) and my Mac.

            Show
            rowen Russell Owen added a comment - Tim Jenness 's fix worked very well. I was able to remove f77.h , which is a huge relief, and it all builds on Jenkins (py2) and my Mac.

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Tim Jenness
              Watchers:
              John Parejko, Russell Owen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.