XMLWordPrintable

#### Details

• Type: Story
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
• Story Points:
2
• Sprint:
• Team:

#### Description

Note: until we have the new WCS code further along it seems premature to add starlink_ast to lsst_distrib

#### Activity

Hide
Russell Owen added a comment -

I think Tim Jenness is satisfied (please correct me if not!) so John Parejko please mark this as reviewed when you are also satisfied.

Show
Russell Owen added a comment - I think Tim Jenness is satisfied (please correct me if not!) so John Parejko please mark this as reviewed when you are also satisfied.
Hide
John Parejko added a comment -

Thanks, that's more managable.

Show
John Parejko added a comment - Thanks, that's more managable.
Hide
Russell Owen added a comment -

Jenkins fails to build it. Here is a console log: https://ci.lsst.codes/job/stack-os-matrix/label=centos-7,python=py2/17142//consoleFull

and here is an excerpt:

 [2016-10-12T00:29:01.067547Z] In file included from grf_pgplot.c:78:0: [2016-10-12T00:29:01.067650Z] grf_pgplot.c:131:91: error: unknown type name 'text_length' [2016-10-12T00:29:01.067702Z] F77_SUBROUTINE(pgptxt)( REAL(x), REAL(y), REAL(angle), REAL(fjust), CHARACTER(text) TRAIL(text) ); [2016-10-12T00:29:01.067754Z] ^ [2016-10-12T00:29:01.067787Z] f77.h:407:36: note: in definition of macro 'TRAIL' [2016-10-12T00:29:01.067818Z] #define TRAIL(X) , X ## _length [2016-10-12T00:29:01.067846Z] ^ 

The command rebuild starlink_ast works fine on my Mac, but that does not have fortran available. That file f77.h has also been troublesome because the installation step modifies it (at least on my Mac) rendering it unusable and leaving it listed as modified, meaning it would be all too easy to commit the broken version. However, that is not what happened in this case.

Show
Russell Owen added a comment - Jenkins fails to build it. Here is a console log: https://ci.lsst.codes/job/stack-os-matrix/label=centos-7,python=py2/17142//consoleFull and here is an excerpt: [2016-10-12T00:29:01.067547Z] In file included from grf_pgplot.c:78:0: [2016-10-12T00:29:01.067650Z] grf_pgplot.c:131:91: error: unknown type name 'text_length' [2016-10-12T00:29:01.067702Z] F77_SUBROUTINE(pgptxt)( REAL(x), REAL(y), REAL(angle), REAL(fjust), CHARACTER(text) TRAIL(text) ); [2016-10-12T00:29:01.067754Z] ^ [2016-10-12T00:29:01.067787Z] f77.h:407:36: note: in definition of macro 'TRAIL' [2016-10-12T00:29:01.067818Z] #define TRAIL(X) , X ## _length [2016-10-12T00:29:01.067846Z] ^ The command rebuild starlink_ast works fine on my Mac, but that does not have fortran available. That file f77.h has also been troublesome because the installation step modifies it (at least on my Mac) rendering it unusable and leaving it listed as modified, meaning it would be all too easy to commit the broken version. However, that is not what happened in this case.
Hide
Tim Jenness added a comment -

I have a possible fix for this upstream: https://github.com/Starlink/ast/pull/2

Show
Tim Jenness added a comment - I have a possible fix for this upstream: https://github.com/Starlink/ast/pull/2
Hide
Russell Owen added a comment -

Tim Jenness's fix worked very well. I was able to remove f77.h, which is a huge relief, and it all builds on Jenkins (py2) and my Mac.

Show
Russell Owen added a comment - Tim Jenness 's fix worked very well. I was able to remove f77.h , which is a huge relief, and it all builds on Jenkins (py2) and my Mac.

#### People

Assignee:
Russell Owen
Reporter:
Russell Owen
Reviewers:
Tim Jenness
Watchers:
John Parejko, Russell Owen, Tim Jenness