Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7987

Ambiguous conversion between spherical coordinates and unit vectors

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Sprint:
      Alert Production F16 - 11, Alert Production F16 - 11b, Alert Production F16 - 11c
    • Team:
      Alert Production

      Description

      The sphgeom::LonLat and sphgeom::UnitVector3d classes provide constructors for converting between the two types. However, the axis convention used for the conversion is left unspecified, limiting the situations where these classes' interoperability can be used.

      I propose that the axis convention currently used by the implementations of these classes be made part of their APIs, so that external code knows what results to expect:

      (0°, 0°) <--> <1, 0, 0>
      (90°, 0°) <--> <0, 1, 0>
      (*, 90°) <--> <0, 0, 1>
      

        Attachments

          Activity

          Hide
          krzys Krzysztof Findeisen added a comment -

          Serge Monkewitz, if your offer to review this ticket is still open, I'd appreciate you taking a look at it.

          Show
          krzys Krzysztof Findeisen added a comment - Serge Monkewitz , if your offer to review this ticket is still open, I'd appreciate you taking a look at it.
          Hide
          smonkewitz Serge Monkewitz added a comment -

          Looks good; minor comments in PR

          Show
          smonkewitz Serge Monkewitz added a comment - Looks good; minor comments in PR
          Hide
          krzys Krzysztof Findeisen added a comment -

          Merged with requested changes.

          Show
          krzys Krzysztof Findeisen added a comment - Merged with requested changes.

            People

            Assignee:
            krzys Krzysztof Findeisen
            Reporter:
            krzys Krzysztof Findeisen
            Reviewers:
            Serge Monkewitz
            Watchers:
            Krzysztof Findeisen, Serge Monkewitz
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.