Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-7987

Ambiguous conversion between spherical coordinates and unit vectors

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Epic Link:
    • Sprint:
      Alert Production F16 - 11, Alert Production F16 - 11b, Alert Production F16 - 11c
    • Team:
      Alert Production

      Description

      The sphgeom::LonLat and sphgeom::UnitVector3d classes provide constructors for converting between the two types. However, the axis convention used for the conversion is left unspecified, limiting the situations where these classes' interoperability can be used.

      I propose that the axis convention currently used by the implementations of these classes be made part of their APIs, so that external code knows what results to expect:

      (0°, 0°) <--> <1, 0, 0>
      		 
      (90°, 0°) <--> <0, 1, 0>
      		 
      (*, 90°) <--> <0, 0, 1>

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          No builds found.
          krzys Krzysztof Findeisen created issue -
          krzys Krzysztof Findeisen made changes -
          Field Original Value New Value
          Epic Link DM-7640 [ 26833 ]
          krzys Krzysztof Findeisen made changes -
          Epic Link DM-7640 [ 26833 ] DM-7362 [ 26448 ]
          krzys Krzysztof Findeisen made changes -
          Sprint Alert Production F16 - 11 [ 289 ]
          krzys Krzysztof Findeisen made changes -
          Rank Ranked higher
          krughoff Simon Krughoff made changes -
          Sprint Alert Production F16 - 11 [ 289 ] Alert Production F16 - 11, Alert Production F16 - 11b [ 289, 295 ]
          krughoff Simon Krughoff made changes -
          Rank Ranked higher
          krughoff Simon Krughoff made changes -
          Sprint Alert Production F16 - 11, Alert Production F16 - 11b [ 289, 295 ] Alert Production F16 - 11, Alert Production F16 - 11b, Alert Production F16 - 11c [ 289, 295, 296 ]
          krzys Krzysztof Findeisen made changes -
          Status To Do [ 10001 ] In Progress [ 3 ]
          Hide
          Permalink
          krzys Krzysztof Findeisen added a comment -

          Serge Monkewitz, if your offer to review this ticket is still open, I'd appreciate you taking a look at it.

          Show
          krzys Krzysztof Findeisen added a comment - Serge Monkewitz , if your offer to review this ticket is still open, I'd appreciate you taking a look at it.
          krzys Krzysztof Findeisen made changes -
          Reviewers Serge Monkewitz [ smonkewitz ]
          Status In Progress [ 3 ] In Review [ 10004 ]
          Hide
          Permalink
          smonkewitz Serge Monkewitz added a comment -

          Looks good; minor comments in PR

          Show
          smonkewitz Serge Monkewitz added a comment - Looks good; minor comments in PR
          smonkewitz Serge Monkewitz made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          Hide
          Permalink
          krzys Krzysztof Findeisen added a comment -

          Merged with requested changes.

          Show
          krzys Krzysztof Findeisen added a comment - Merged with requested changes.
          krzys Krzysztof Findeisen made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]
          rhl Robert Lupton made changes -
          Labels SciencePipelines documentation, SciencePipelines documentation documentation,
          rhl Robert Lupton made changes -
          Labels SciencePipelines documentation documentation, SciencePipelines documentation

            People

            Assignee:
            krzys Krzysztof Findeisen
            Reporter:
            krzys Krzysztof Findeisen
            Reviewers:
            Serge Monkewitz
            Watchers:
            Krzysztof Findeisen, Serge Monkewitz
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.