Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-8009

Reduce verbosity in starting tasks

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: obs_base, pipe_base
    • Labels:
      None

      Description

      Robert Lupton and Jim Bosch pointed out that the stack is too chatty here:

      reduceArc.py $PFS_DATA_DIR --rerun $whoami/talk --id visit=4 --clobber-versions
      root INFO: Config override file does not exist: '/Users/rhl/LSST/obs/pfs/config/reduceArcTask.py'
      root INFO: Config override file does not exist: '/Users/rhl/LSST/obs/pfs/config/pfs/reduceArcTask.py'
      root INFO: input=/Users/rhl/PFS/Data
      root INFO: calib=None
      root INFO: output=/Users/rhl/PFS/Data/rerun/rhl/talk
      CameraMapper INFO: Loading registry registry from /Users/rhl/PFS/Data/rerun/rhl/talk/_parent/registry.sqlite3
      CameraMapper INFO: Loading calibRegistry registry from /Users/rhl/PFS/Data/CALIB/calibRegistry.sqlite3
      

      and we should consider changing most of the above lines to DEBUG level.

        Attachments

          Issue Links

            Activity

            Hide
            hchiang2 Hsin-Fang Chiang added a comment -

            If there is no objection I can go ahead and change those to DEBUG level.

            Show
            hchiang2 Hsin-Fang Chiang added a comment - If there is no objection I can go ahead and change those to DEBUG level.
            Hide
            hchiang2 Hsin-Fang Chiang added a comment -

            From the comments in RFC-203 it seems to me we have a consensus in lowering these messages from INFO to DEBUG level. I'm opening two PRs, in pipe_base and obs_base. Russell Owen may you please review pipe_base, Nate Pease [X] may you please review obs_base, and see if you agree with the changes?

            pipe_base:

            root INFO: Config override file does not exist: '/Users/rhl/LSST/obs/pfs/config/reduceArcTask.py'
            root INFO: Config override file does not exist: '/Users/rhl/LSST/obs/pfs/config/pfs/reduceArcTask.py'
            root INFO: input=/Users/rhl/PFS/Data
            root INFO: calib=None
            root INFO: output=/Users/rhl/PFS/Data/rerun/rhl/talk
            

            My argument is there is nothing to pay special attention to if no config overrides are applied; what file paths were searched will become DEBUG messages. If a config override file is found and applied, there is still a INFO-level log message noting what is applied.

            The input/calib/output are implied by the command. I find this INFO message recently added by Russell Owen in DM-7844 more informative in a more cnocise way. It logs exactly what was ran.

            obs_base:

            CameraMapper INFO: Loading registry registry from /Users/rhl/PFS/Data/rerun/rhl/talk/_parent/registry.sqlite3
            CameraMapper INFO: Loading calibRegistry registry from /Users/rhl/PFS/Data/CALIB/calibRegistry.sqlite3
            

            Loading the traditional registries will become DEBUG messages. Loading Posix registries is still an INFO-level message (or probably should become DEBUG too?) In a way these are all implementation details, but I can see why this may be of interest during production run.

            Show
            hchiang2 Hsin-Fang Chiang added a comment - From the comments in RFC-203 it seems to me we have a consensus in lowering these messages from INFO to DEBUG level. I'm opening two PRs, in pipe_base and obs_base . Russell Owen may you please review pipe_base , Nate Pease [X] may you please review obs_base , and see if you agree with the changes? pipe_base : root INFO: Config override file does not exist: '/Users/rhl/LSST/obs/pfs/config/reduceArcTask.py' root INFO: Config override file does not exist: '/Users/rhl/LSST/obs/pfs/config/pfs/reduceArcTask.py' root INFO: input=/Users/rhl/PFS/Data root INFO: calib=None root INFO: output=/Users/rhl/PFS/Data/rerun/rhl/talk My argument is there is nothing to pay special attention to if no config overrides are applied; what file paths were searched will become DEBUG messages. If a config override file is found and applied, there is still a INFO-level log message noting what is applied. The input/calib/output are implied by the command. I find this INFO message recently added by Russell Owen in DM-7844 more informative in a more cnocise way. It logs exactly what was ran. obs_base : CameraMapper INFO: Loading registry registry from /Users/rhl/PFS/Data/rerun/rhl/talk/_parent/registry.sqlite3 CameraMapper INFO: Loading calibRegistry registry from /Users/rhl/PFS/Data/CALIB/calibRegistry.sqlite3 Loading the traditional registries will become DEBUG messages. Loading Posix registries is still an INFO-level message (or probably should become DEBUG too?) In a way these are all implementation details, but I can see why this may be of interest during production run.
            Hide
            npease Nate Pease [X] (Inactive) added a comment -

            the changes to obs_base look fine; I'm done reviewing.

            Show
            npease Nate Pease [X] (Inactive) added a comment - the changes to obs_base look fine; I'm done reviewing.
            Hide
            rowen Russell Owen added a comment -

            The changes to pipe_base look good to me.

            Show
            rowen Russell Owen added a comment - The changes to pipe_base look good to me.
            Hide
            hchiang2 Hsin-Fang Chiang added a comment -

            Thank you both for reviewing!

            Merged and done.

            Show
            hchiang2 Hsin-Fang Chiang added a comment - Thank you both for reviewing! Merged and done.

              People

              Assignee:
              hchiang2 Hsin-Fang Chiang
              Reporter:
              hchiang2 Hsin-Fang Chiang
              Reviewers:
              Nate Pease [X] (Inactive), Russell Owen
              Watchers:
              Hsin-Fang Chiang, Jim Bosch, Nate Pease [X] (Inactive), Robert Lupton, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.